Examples menu document by janat08 · Pull Request #880 · cyclejs/cyclejs

janat08 · 2019-03-24T22:07:11Z

###--------------------------------------------------------###
docs(examples): examples menu document

Surmised various example applications, and described principles demonstrated in simple examples.

ISSUES CLOSED: #480
###--------------------------------------------------------###

staltz · 2019-03-25T08:48:02Z

Hi @janat08 :)
Thanks for submitting this PR, we appreciate the desire to help. Before merging this PR could you notice and fix typos in the readme text, and then rewrite the commit message so that it conforms to the commit convention? (You probably saw a note about this in the PR template)

janat08 · 2019-03-25T19:04:40Z

I was hoping to get the bounty from issuehunt, even if the issue was meant for commenting the code.

jopek

👍

staltz · 2019-04-26T10:02:20Z

I guess I'm waiting for this step before merging:

and then rewrite the commit message so that it conforms to the commit convention? (You probably saw a note about this in the PR template)

:)

###--------------------------------------------------------### docs(examples): examples menu document Surmised various example applications, and described principles demonstrated in simple examples. ISSUES CLOSED: cyclejs#480 ###--------------------------------------------------------###

janat08 · 2019-04-26T13:29:23Z

Thanks for clarification. I use gitkraken gui app, so neither the pull or commit templates showed up.

sonarqubecloud · 2025-02-18T13:27:55Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

staltz reviewed Mar 25, 2019

View reviewed changes