fix pyproject.toml not to install various files into site-packages#154
Merged
Conversation
Fix the `include` directives to include the specified files in sdist only. Without explicit format, they cause the specified files to be included both in sdist and in wheels, which in turn means they're going to be installed into the top-level directory of site-packages!
Codecov Report
@@ Coverage Diff @@
## master #154 +/- ##
=======================================
Coverage 94.54% 94.54%
=======================================
Files 3 3
Lines 477 477
=======================================
Hits 451 451
Misses 26 26 Help us with your feedback. Take ten seconds to tell us how you rate us. |
Owner
|
Thanks, and sorry for that! I'll release a new version very soon. |
Contributor
Author
|
Thanks! |
Owner
|
FYI: 1.0.5 has just been released with your fix. |
csernazs
added a commit
that referenced
this pull request
Sep 3, 2022
The main purpose of this test is to ensure that whell and sdist are having the contents we expect, and no other contents. Partially, this is to avoid issues described in #154. It also checks classifiers that they are in-sync with the python version described in the toml.
csernazs
added a commit
that referenced
this pull request
Sep 3, 2022
The main purpose of this test is to ensure that whell and sdist are having the contents we expect, and no other contents. Partially, this is to avoid issues described in #154. It also checks classifiers that they are in-sync with the python version described in the toml.
csernazs
added a commit
that referenced
this pull request
Sep 3, 2022
The main purpose of this test is to ensure that whell and sdist are having the contents we expect, and no other contents. Partially, this is to avoid issues described in #154. It also checks classifiers that they are in-sync with the python version described in the toml.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix the
includedirectives to include the specified files in sdistonly. Without explicit format, they cause the specified files to be
included both in sdist and in wheels, which in turn means they're going
to be installed into the top-level directory of site-packages!