Skip to content

Wide space input support #574

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
WilcoBT wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Wide space input support #574

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
cad2baa
Add support for wide characters.
Apr 2, 2015
2259206
Added test and processed comments from the merge thread.
Apr 7, 2015
a587cbf
Educated guess to fix the clang compiler complaining about wcslen.
Apr 7, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Educated guess to fix the clang compiler complaining about wcslen.
  • Loading branch information
wilcob authored and wilcob committed Apr 7, 2015
commit a587cbf3b0f6096dd436eea84ec774cedbf3d139
1 change: 1 addition & 0 deletions include/CppUTest/CommandLineTestRunner.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,7 @@
#include "TestOutput.h"
#include "CommandLineArguments.h"
#include "TestFilter.h"
#include <cwchar>
Copy link
Copy Markdown
Member

@basvodde basvodde Apr 7, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Direct dependencies with Lib C aren't allowed in CppUTest. You'd need to wrap the methods in PlatformSpecific to deal with portability to "less supported" platforms.

Copy link
Copy Markdown
Author

@WilcoBT WilcoBT Apr 7, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, that makes sense.

Copy link
Copy Markdown
Contributor

@arstrube arstrube Apr 7, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@basvodde I don't know offhand about wchar_t. What I do know is that, due to limited memory, we had to use the non-std-C++ lib option. I suppose that means at least the conversion functions won't be available for the cl2000.

Copy link
Copy Markdown
Contributor

@arstrube arstrube Apr 7, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems to be a c lib though.

Copy link
Copy Markdown
Member

@basvodde basvodde Apr 7, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, though we are going to have problems with wchar_t not being a type without #include...


class JUnitTestOutput;
class TestRegistry;
Expand Down