pointerArithBool: Updated error message

danmar · danmar · commit aa65799c19d1 · 2013-12-25T19:56:00.000+01:00
diff --git a/lib/checkbool.cpp b/lib/checkbool.cpp
@@ -551,5 +551,6 @@ void CheckBool::pointerArithBoolError(const Token *tok)
     reportError(tok,
                 Severity::error,
                 "pointerArithBool",
-                "Converting pointer arithmetic result to bool. Either a dereference is forgot, or pointer overflow is required to get a false value");
+                "Converting pointer arithmetic result to bool. The bool is always true unless there is undefined behaviour.\n"
+                "Converting pointer arithmetic result to bool. The boolean result is always true unless there is pointer arithmetic overflow, and overflow is undefined behaviour. Probably a dereference is forgotten.");
 }
diff --git a/test/testbool.cpp b/test/testbool.cpp
@@ -877,12 +877,12 @@ class TestBool : public TestFixture {
         check("void f(char *p) {\n"
               "    if (p+1){}\n"
               "}");
-        ASSERT_EQUALS("[test.cpp:2]: (error) Converting pointer arithmetic result to bool. Either a dereference is forgot, or pointer overflow is required to get a false value\n", errout.str());
+        ASSERT_EQUALS("[test.cpp:2]: (error) Converting pointer arithmetic result to bool. The bool is always true unless there is undefined behaviour.\n", errout.str());
 
         check("void f(char *p) {\n"
               "    if (p && p+1){}\n"
               "}");
-        ASSERT_EQUALS("[test.cpp:2]: (error) Converting pointer arithmetic result to bool. Either a dereference is forgot, or pointer overflow is required to get a false value\n", errout.str());
+        ASSERT_EQUALS("[test.cpp:2]: (error) Converting pointer arithmetic result to bool. The bool is always true unless there is undefined behaviour.\n", errout.str());
     }
 };
 

Original file line number	Diff line number	Diff line change
`@@ -551,5 +551,6 @@ void CheckBool::pointerArithBoolError(const Token *tok)`
`551`	`551`	`reportError(tok,`
`552`	`552`	`Severity::error,`
`553`	`553`	`"pointerArithBool",`
`554`		`- "Converting pointer arithmetic result to bool. Either a dereference is forgot, or pointer overflow is required to get a false value");`
	`554`	`+ "Converting pointer arithmetic result to bool. The bool is always true unless there is undefined behaviour.\n"`
	`555`	`+ "Converting pointer arithmetic result to bool. The boolean result is always true unless there is pointer arithmetic overflow, and overflow is undefined behaviour. Probably a dereference is forgotten.");`
`555`	`556`	`}`