Uninitialized variables: Fixed false positive taking value of pointer that is allocated but not initialized

danmar · danmar · commit 6182394966fe · 2013-12-25T14:00:27.000+01:00
diff --git a/lib/checkuninitvar.cpp b/lib/checkuninitvar.cpp
@@ -1757,7 +1757,7 @@ bool CheckUninitVar::isVariableUsage(const Token *vartok, bool pointer, bool all
         }
     }
 
-    if (Token::Match(vartok->previous(), "= %var% ;|%cop%"))
+    if (!alloc && Token::Match(vartok->previous(), "= %var% ;|%cop%"))
         return true;
 
     if (Token::Match(vartok->previous(), "? %var%")) {
diff --git a/test/testuninitvar.cpp b/test/testuninitvar.cpp
@@ -3348,6 +3348,12 @@ class TestUninitVar : public TestFixture {
                         "}\n");
         ASSERT_EQUALS("", errout.str());
 
+        checkUninitVar2("void f() {\n"
+                        "    char *p = malloc(100);\n"
+                        "    x = p;\n"
+                        "}\n");
+        ASSERT_EQUALS("", errout.str());
+
         // function parameter (treat it as initialized until malloc is used)
         checkUninitVar2("int f(int *p) {\n"
                         "    if (*p == 1) {}\n" // no error

Original file line number	Diff line number	Diff line change
`@@ -1757,7 +1757,7 @@ bool CheckUninitVar::isVariableUsage(const Token *vartok, bool pointer, bool all`
`1757`	`1757`	`}`
`1758`	`1758`	`}`
`1759`	`1759`
`1760`		`- if (Token::Match(vartok->previous(), "= %var% ;\|%cop%"))`
	`1760`	`+ if (!alloc && Token::Match(vartok->previous(), "= %var% ;\|%cop%"))`
`1761`	`1761`	`return true;`
`1762`	`1762`
`1763`	`1763`	`if (Token::Match(vartok->previous(), "? %var%")) {`