feature / #77 show warnings for included header files along with source files#84
Open
davidramnero wants to merge 2 commits into
Open
feature / #77 show warnings for included header files along with source files#84davidramnero wants to merge 2 commits into
davidramnero wants to merge 2 commits into
Conversation
… to clear them from diagnostics
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To not clutter the problems tab with header file errors we need a fairly intricate solution to keep track of where header file errors are coming from (so we can clear diagnostics for a header file when the source file whose analysis generated them are closed).
This solution supports stack traces with locations in multiple different files
Previous bug where problems for a given file would not get cleared when it's tab is closed is also fixed