feature / #68 skip running checks if file content has not changed#72
Conversation
| return; | ||
| } | ||
|
|
||
| if ((Object.keys(documentHashMemory) as Array<string>).includes(document.fileName)) { |
There was a problem hiding this comment.
can there be some situation when results are not shown for a file and user wants to save to trigger analysis? is cppcheck always executed when a file is opened? even if user doesn't open the file but vscode opens the file automatically during startup or something?
There was a problem hiding this comment.
Yeah this is a good question, I am trying to think of a way to make it safe from ending up in a kind of stuck mode such as you describe, but I am not sure we can be completely safe from it happening.
Maybe this feature isn't worth the risk?
There was a problem hiding this comment.
I am not sure how much of a problem it is to run checks a little more than necessary tbh
There was a problem hiding this comment.
if you only calculate the hash when the file is saved we should be safe.. if you feel this is done then I am happy.
No description provided.