Skip to content

Fix #14818 FP returnDanglingLifetime when passing c_str() to function #8750

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
chrchr-github wants to merge 2 commits into
base: main
Choose a base branch
from
+11 −0
Open

Fix #14818 FP returnDanglingLifetime when passing c_str() to function #8750

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1322c81
Update valueflow.cpp
chrchr-github Jul 23, 2026
0a7f693
Update testautovariables.cpp
chrchr-github Jul 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions lib/valueflow.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2536,6 +2536,8 @@ static void valueFlowLifetimeFunction(Token *tok, const TokenList &tokenlist, Er
}
if (Function::returnsReference(f))
return;
if (astIsContainerString(tok->next()) && !astIsContainerView(tok->next()))

@pfultz2 pfultz2 Jul 23, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems like it would be better to call ValueFlow::isLifetimeBorrowed here, which getParentValueType should get the correct valuetype with a function return.

return;
std::vector<const Token*> returns = Function::findReturns(f);
const bool inconclusive = returns.size() > 1;
bool update = false;
Expand Down
9 changes: 9 additions & 0 deletions test/testautovariables.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2962,6 +2962,15 @@ class TestAutoVariables : public TestFixture {
" int m;\n"
"}\n");
ASSERT_EQUALS("", errout_str());

check("std::string to_string(const char* p) {\n" // #14818
" return p;\n"
"}\n"
"std::string get() {\n"
" std::string s;\n"
" return to_string(s.c_str());\n"
"}\n");
ASSERT_EQUALS("", errout_str());
}

void danglingLifetimeContainerView()
Expand Down
Loading