Fix #14850 (Compilation fails on oraclelinux:8 (g++ 8.5.0 released in 2021))#8654
Open
danmar wants to merge 1 commit into
Open
Fix #14850 (Compilation fails on oraclelinux:8 (g++ 8.5.0 released in 2021))#8654danmar wants to merge 1 commit into
danmar wants to merge 1 commit into
Conversation
firewave
requested changes
Jun 16, 2026
firewave
left a comment
Collaborator
There was a problem hiding this comment.
This feels like a compiler bug to me.
We should make noexcept optional as a hack for this compiler in question instead of rolling back perfectly valid code.
Collaborator
|
See also https://trac.cppcheck.net/ticket/14851 to make sure such problems are not just platform-specific. |
Collaborator
Author
|
@firewave thanks for your review.. I also feel these errors are pretty weird. do you have some more specifiec suggestion how we hack it.. how about : And then I use NOEXCEPT in the constructor and assignment operator? So when compiling on oraclelinux I will have to provide |
| Settings(Settings&&) noexcept; | ||
| Settings& operator=(Settings&&) noexcept; | ||
| Settings(Settings&&) NOEXCEPT; | ||
| Settings& operator=(Settings&&) NOEXCEPT; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.