Skip to content

Fix #14785/14786 FN unusedStructMember (scoped standard type, smart pointer) #8576

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
chrchr-github wants to merge 4 commits into
base: main
Choose a base branch
from
+15 −1
Open

Fix #14785/14786 FN unusedStructMember (scoped standard type, smart pointer) #8576

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
729a96b
Update checkunusedvar.cpp
chrchr-github May 26, 2026
72b2e7e
Update testunusedvar.cpp
chrchr-github May 26, 2026
d1f7aec
Trigger CI
web-flow May 26, 2026
bcc9742
Fix #14786 inconsistent unusedStructMember with std::unique_ptr
web-flow May 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion lib/checkunusedvar.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1641,7 +1641,8 @@ void CheckUnusedVar::checkStructMemberUsage()

for (const Variable &var : scope.varlist) {
// only warn for variables without side effects
if (!var.typeStartToken()->isStandardType() && !var.isPointer() && !astIsContainer(var.nameToken()) && !mTokenizer->getSymbolDatabase()->isRecordTypeWithoutSideEffects(var.type()))
if (!(var.valueType() && var.valueType()->type >= ValueType::VOID) && !var.isPointer() && !astIsContainer(var.nameToken()) &&
!astIsSmartPointer(var.nameToken()) && !mTokenizer->getSymbolDatabase()->isRecordTypeWithoutSideEffects(var.type()))
continue;
if (isInherited && !var.isPrivate())
continue;
Expand Down
13 changes: 13 additions & 0 deletions test/testunusedvar.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,6 +79,7 @@ class TestUnusedVar : public TestFixture {
TEST_CASE(structmember31); // #14130
TEST_CASE(structmember32); // #14483
TEST_CASE(structmember33);
TEST_CASE(structmember34);
TEST_CASE(structmember_macro);
TEST_CASE(structmember_template_argument); // #13887 - do not report that member used in template argument is unused
TEST_CASE(classmember);
Expand Down Expand Up @@ -2088,6 +2089,18 @@ class TestUnusedVar : public TestFixture {
ASSERT_EQUALS("[test.cpp:2:23]: (style) struct member 'S::mp' is never used. [unusedStructMember]\n", errout_str());
}

void structmember34() {
checkStructMemberUsage("struct S {\n" // #14785
" std::int32_t i;\n"
"};\n");
ASSERT_EQUALS("[test.cpp:2:16]: (style) struct member 'S::i' is never used. [unusedStructMember]\n", errout_str());

checkStructMemberUsage("struct S {\n" // #14786
" std::unique_ptr<int> p;\n"
"};\n");
ASSERT_EQUALS("[test.cpp:2:24]: (style) struct member 'S::p' is never used. [unusedStructMember]\n", errout_str());
}

void structmember_macro() {
checkStructMemberUsageP("#define S(n) struct n { int a, b, c; };\n"
"S(unused);\n");
Expand Down
Loading