Skip to content

Fix #14762 FN knownConditionTrueFalse (default constructed container) #8575

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
chrchr-github wants to merge 2 commits into
base: main
Choose a base branch
from
+15 −2
Open

Fix #14762 FN knownConditionTrueFalse (default constructed container) #8575

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6c9bcbc
Update vf_settokenvalue.cpp
chrchr-github May 26, 2026
719e661
Update testvalueflow.cpp
chrchr-github May 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions lib/vf_settokenvalue.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -291,9 +291,9 @@ namespace ValueFlow

combineValueProperties(value1, value2, result);

if (Token::simpleMatch(parent, "==") && result.intvalue)
if (Token::simpleMatch(parent, "==") && result.intvalue && !(value1.intvalue == 0 && value2.intvalue == 0))
continue;
if (Token::simpleMatch(parent, "!=") && !result.intvalue)
if (Token::simpleMatch(parent, "!=") && !result.intvalue && !(value1.intvalue == 0 && value2.intvalue == 0))
continue;

setTokenValue(parent, std::move(result), settings);
Expand Down
13 changes: 13 additions & 0 deletions test/testvalueflow.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9225,6 +9225,19 @@ class TestValueFlow : public TestFixture {
"}\n";
ASSERT_EQUALS(false, testValueOfX(code, 5U, 1));
ASSERT_EQUALS(false, testValueOfX(code, 5U, 0));

code = "bool f() {\n"
" std::string s1, s2;\n"
" bool x = (s1 == s2);\n"
" return x;\n"
"}\n"
"bool g() {\n"
" std::string s1, s2;\n"
" bool x = (s1 != s2);\n"
" return x;\n"
"}\n";
ASSERT_EQUALS(true, testValueOfXKnown(code, 4U, 1));
ASSERT_EQUALS(true, testValueOfXKnown(code, 9U, 0));
}

void valueFlowBailoutIncompleteVar() {
Expand Down