You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
emptyString is used for const std::string& return values and as an optimization in some cases. But those are insolated cases.
The goal is to remove it from config.h because that file should only contain "configuration" related stuff.
Also the <string> makes this one of the heavier headers.
Even worse though is the fact that the include affects the preprocessor checks. We are (were?) checking non-compiler/built-in defines which were transiently included leading to portability issues.
firewave
changed the title
removed unnecessary usage of emptyString
reduced unnecessary usage of emptyStringJan 16, 2025
Even worse though is the fact that the include affects the preprocessor checks. We are (were?) checking non-compiler/built-in defines which were transiently included leading to portability issues.
I think this also implies that config.h always needs to be the very first include. Something for later ... as usual.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.