Skip to content

fixed some compilation errors with USE_BOOST_INT128 by using proper types#7073

Merged
firewave merged 2 commits into
cppcheck-opensource:mainfrom
firewave:bigint-xx
Dec 23, 2024
Merged

fixed some compilation errors with USE_BOOST_INT128 by using proper types#7073
firewave merged 2 commits into
cppcheck-opensource:mainfrom
firewave:bigint-xx

Conversation

@firewave
Copy link
Copy Markdown
Collaborator

@firewave firewave commented Dec 4, 2024

No description provided.

@firewave firewave force-pushed the bigint-xx branch 2 times, most recently from c016ba9 to 797d618 Compare December 5, 2024 00:32
@firewave firewave marked this pull request as ready for review December 5, 2024 00:33
@firewave
Copy link
Copy Markdown
Collaborator Author

firewave commented Dec 5, 2024 •
edited
Loading 

     4>D:\a\cppcheck\cppcheck\lib\valueflow.cpp(6448,61): error C2668: 'makeContainerSizeValue': ambiguous call to overloaded function [D:\a\cppcheck\cppcheck\lib\cppcheck.vcxproj]
       D:\a\cppcheck\cppcheck\lib\valueflow.cpp(6344,38): message : could be 'std::vector<ValueFlow::Value,std::allocator<ValueFlow::Value>> makeContainerSizeValue(const Token *,bool)' [D:\a\cppcheck\cppcheck\lib\cppcheck.vcxproj]
       D:\a\cppcheck\cppcheck\lib\valueflow.cpp(6335,25): message : or       'ValueFlow::Value makeContainerSizeValue(MathLib::bigint,bool)' [D:\a\cppcheck\cppcheck\lib\cppcheck.vcxproj]
       D:\a\cppcheck\cppcheck\lib\valueflow.cpp(6448,61): message : while trying to match the argument list '(size_t, bool)' [D:\a\cppcheck\cppcheck\lib\cppcheck.vcxproj]

GCC also fails but has a much bigger message.

I filed llvm/llvm-project#118801 upstream about the Clang issue the initial change exposed.

@firewave firewave mentioned this pull request Dec 8, 2024
Merged
@firewave
Copy link
Copy Markdown
Collaborator Author

firewave commented Dec 23, 2024

More than two weeks without any feedback- merging.

@firewave firewave merged commit b090590 into cppcheck-opensource:main Dec 23, 2024
@firewave firewave deleted the bigint-xx branch December 23, 2024 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@firewave