Skip to content

ValueFlow: delayed some code until necessary and added some early outs#7052

Merged
firewave merged 9 commits into
cppcheck-opensource:mainfrom
firewave:vf-opt-yyy
Dec 5, 2024
Merged

ValueFlow: delayed some code until necessary and added some early outs#7052
firewave merged 9 commits into
cppcheck-opensource:mainfrom
firewave:vf-opt-yyy

Conversation

@firewave

@firewave firewave commented Nov 30, 2024

Copy link
Copy Markdown
Collaborator

No description provided.

@firewave
valueflow.cpp: only perform call eval() in parseBinaryIntOp() whe…
70051ae 
…n result is required
@firewave
valueflow.cpp: do not copy values in parseCompareEachInt() until ne…
a12f552 
…eded
@firewave
valueflow.cpp: do not create value in valueFlowIterators() until un…
7f47e88 
…necessary
@firewave
programmemory.cpp: do not copy value in Executor::execute() until n…
270121c 
…ecessary
@firewave
valueflow.cpp: do not create value in valueFlowSameExpressions() un…
a4c41b5 
…til necessary
@firewave
valueflow.cpp: do not perform function calls in minUnsignedValue() …
4b013f2 
…until necessary
@firewave
valueflow.cpp: added some early outs in `ConditionHandler::beforeCond…
511c0aa 
…ition()`
@firewave
programmemory.cpp: do not perform call in `Executor::executeMultiCond…
76b2aef 
…ition()` until necessary
@firewave
valueflow.cpp: added early out in valueFlowConditionExpressions()
9c2a6b4
@firewave

firewave commented Nov 30, 2024 •
edited
Loading

Copy link
Copy Markdown
Collaborator Author

A first round of local testing showed very small improvements. The CI is also mainly slightly improved with one outlier (but given how much longer it takes that might just be more visible noise).

before

Check time: cli/cmdlineparser.cpp: 1006.88s
[...]
Check time: lib/checkio.cpp: 208.024s
[...]
Check time: lib/vf_settokenvalue.cpp: 35.0221s
[...]
Check time: lib/tokenize.cpp: 265.461s

after

Check time: cli/cmdlineparser.cpp: 1018.34s
[...]
Check time: lib/checkio.cpp: 202.278s
[...]
Check time: lib/vf_settokenvalue.cpp: 32.4819s
[...]
Check time: lib/tokenize.cpp: 258.276s

@firewave firewave marked this pull request as ready for review November 30, 2024 14:34
@firewave firewave changed the title ValueFlow: delayed some function calls until necessary and added some early outs ValueFlow: delayed some code until necessary and added some early outs Nov 30, 2024
@firewave firewave merged commit af4e5b3 into cppcheck-opensource:main Dec 5, 2024
@firewave firewave deleted the vf-opt-yyy branch December 5, 2024 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@danmar danmar danmar approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@firewave @danmar