Skip to content

Fix #13142 FP knownConditionTrueFalse when constructing container from iterator adaptor #6832

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
chrchr-github merged 2 commits into from
Sep 27, 2024
Merged

Fix #13142 FP knownConditionTrueFalse when constructing container from iterator adaptor #6832

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7ddc4f4
Update valueflow.cpp
chrchr-github Sep 26, 2024
d0797ad
Update testvalueflow.cpp
chrchr-github Sep 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions lib/valueflow.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5377,6 +5377,8 @@ static std::vector<ValueFlow::Value> getInitListSize(const Token* tok,
initList = true;
else if (args.size() == 1 && valueFlowIsSameContainerType(vt, tok->astOperand2(), settings))
initList = false; // copy ctor
else if (args.size() == 2 && (!args[0]->valueType() || !args[1]->valueType())) // might be unknown iterators
initList = false;
}
}
if (!initList)
Expand Down
8 changes: 8 additions & 0 deletions test/testvalueflow.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6992,6 +6992,14 @@ class TestValueFlow : public TestFixture {
" if (s.empty()) {}\n"
"}";
ASSERT_EQUALS("", isPossibleContainerSizeValue(tokenValues(code, "s . empty"), 0));

code = "int f(const std::string& str) {\n"
" std::istringstream iss(str);\n"
" std::vector<std::string> v{ std::istream_iterator<std::string>(iss), {} };\n"
" auto x = v.size();\n"
" return x;\n"
"}";
ASSERT_EQUALS(false, testValueOfXKnown(code, 5U, 2));
}

void valueFlowContainerElement()
Expand Down