ValueFlow: extracted ValueFlowAnalyzer into separate file#6640
Merged
Conversation
Contributor
|
I dont think this should got to a header, it should be in a cpp file with the rest of the analyzers. |
pfultz2
added a commit
to pfultz2/cppcheck
that referenced
this pull request
Jul 26, 2024
…ppcheck-opensource#6640)" This reverts commit d7eb66d.
Collaborator
Author
|
I do not understand the reasoning. Please elaborate. |
Contributor
|
All the analyzer classes should go into the same cpp file. And the header should just expose functions to construct the analyzer(like This change requires duplicating the function declaration in both the header and cpp file and when adding an internal function the header needs to be updated, which doesnt make sense since this is not meant to be an interface, and adds more unnecessary work. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.