Skip to content

Fix 12463: dumpfile: what library are used - #6569

Merged
danmar merged 1 commit into
cppcheck-opensource:mainfrom
swasti16:swasti/12463
Jul 12, 2024
Merged

Fix 12463: dumpfile: what library are used#6569
danmar merged 1 commit into
cppcheck-opensource:mainfrom
swasti16:swasti/12463

Conversation

@swasti16

@swasti16 swasti16 commented Jul 3, 2024

Copy link
Copy Markdown
Contributor

No description provided.

@swasti16
swasti16 force-pushed the swasti/12463 branch 5 times, most recently from 366ddf8 to 2b06bf5 Compare July 3, 2024 13:08
Comment thread lib/settings.h Outdated
Comment thread test/testcppcheck.cpp Outdated
Comment thread lib/cppcheck.cpp Outdated
@swasti16
swasti16 force-pushed the swasti/12463 branch 2 times, most recently from b888d8b to 32ae8ad Compare July 3, 2024 18:22
Comment thread lib/cppcheck.cpp Outdated
@swasti16
swasti16 force-pushed the swasti/12463 branch 3 times, most recently from fd092bc to 5b367d3 Compare July 4, 2024 05:50
@chrchr-github

Copy link
Copy Markdown
Collaborator

Please rebase, the CI failure has been fixed.

@danmar danmar left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit

Comment thread lib/cppcheck.cpp Outdated
std::string CppCheck::getLibraryDumpData() const {
std::string out;
for (const std::string &s : mSettings.libraries) {
out += " <library lib=\"" + s + "\"/>\n";

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it seems to me there are 2 spaces between + s not sure why the formatter accepts that.

@danmar
danmar merged commit c89574c into cppcheck-opensource:main Jul 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants