Use ValueFlow::getSizeOf() in CheckOther#6257
Merged
chrchr-github merged 5 commits intoApr 10, 2024
Merged
Conversation
danmar
approved these changes
Apr 10, 2024
Contributor
|
I don't know if this is intended, but before this commit for the following code: struct SomeClass{
std::string name;
NonClass test;
}
void test(const std::vector<SomeClass>& t){
for(const auto entry : t){
std::cout << entry.name << std::endl;
}
}the following warning was emitted. After this commit you don't get the warning anymore. You only get it if you remove or comment out the line 3 |
Collaborator
Author
This is tracked in https://trac.cppcheck.net/ticket/13696 |
chrchr-github
pushed a commit
that referenced
this pull request
Jun 16, 2025
… empty structs have a size of 1 (#7560) Fixes https://trac.cppcheck.net/ticket/13696 + #6257 (comment) One could argue that the size of a member of an unknown type should be 1 instead of 0 because the member will be at least 1 byte large (if not empty and annotated with `[[no_unique_address]]`) --------- Co-authored-by: Leander Schulten <Leander.Schulten@tetys.de>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.