Skip to content

Fix #12413 ( False positive on Misra 10.3 for bools )#5948

Merged
danmar merged 3 commits into
cppcheck-opensource:mainfrom
0x41head:misra-c2012-10.3
Feb 6, 2024
Merged

Fix #12413 ( False positive on Misra 10.3 for bools )#5948
danmar merged 3 commits into
cppcheck-opensource:mainfrom
0x41head:misra-c2012-10.3

Conversation

@0x41head

@0x41head 0x41head commented Feb 5, 2024

Copy link
Copy Markdown
Contributor

No description provided.

@0x41head
0x41head marked this pull request as ready for review February 5, 2024 17:12
@danmar

danmar commented Feb 6, 2024

Copy link
Copy Markdown
Collaborator

For your information the "Coverage" job is flaky.. don't worry if that fails.

@danmar danmar left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please add test code in cppcheck/addons/test/misra/misra-test.c

@0x41head
0x41head requested a review from danmar February 6, 2024 07:17

@danmar danmar left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm.. in my opinion if CI is happy we can merge this

@danmar

danmar commented Feb 6, 2024

Copy link
Copy Markdown
Collaborator

after we merge this... what name would you like that I add in the AUTHORS file?

@0x41head

0x41head commented Feb 6, 2024

Copy link
Copy Markdown
Contributor Author

after we merge this... what name would you like that I add in the AUTHORS file?

my username works 👍

@danmar
danmar merged commit f6b538e into cppcheck-opensource:main Feb 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants