Skip to content

gui/platforms.h: renamed Platform to PlatformData / Platform: removed unnecessary cppcheck namespace#5545

Merged
danmar merged 1 commit into
cppcheck-opensource:mainfrom
firewave:platforms
Oct 13, 2023
Merged

gui/platforms.h: renamed Platform to PlatformData / Platform: removed unnecessary cppcheck namespace#5545
danmar merged 1 commit into
cppcheck-opensource:mainfrom
firewave:platforms

Conversation

@firewave
Copy link
Copy Markdown
Collaborator

No description provided.

Comment thread gui/mainwindow.cpp

for (int i = 0; i < mPlatforms.getCount(); i++) {
Platform platform = mPlatforms.mPlatforms[i];
PlatformData platform = mPlatforms.mPlatforms[i];
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not your code but platform should probably be a reference. the assignment at line 249 looks strange.

@danmar danmar merged commit ebb877a into cppcheck-opensource:main Oct 13, 2023
@firewave firewave deleted the platforms branch October 16, 2023 09:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants