Don't ignore build*, accidently it ignored all files starts with buil…#5051
Merged
Conversation
Collaborator
|
hmm we don't want to ignore those files you list. but we would like to ignore build folders created by the user. I don't know how to work around that. |
Collaborator
|
This should do it: |
Contributor
Author
|
I updated .gitignore, like @chrchr-github said. If everything is fine please merge this PR. :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pattern build* ignores all files in the repo that starts with build... If developer wants to create a new repository from sources .tar.gz, .zip etc. then ignore doesn't track few files. File
cmake/buildFiles.cmakeis obligatory to proper buildinggit status --ignoredCmake directories are ignored by pattern build/