testrunner: even more SettingsBuilder usage and const cleanups#5030
Merged
Conversation
danmar
approved these changes
May 4, 2023
pfultz2
added a commit
to pfultz2/cppcheck
that referenced
this pull request
May 15, 2023
…anups (cppcheck-opensource#5030)" This reverts commit 5833fc3.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I will look at deduplicating the check implementations and need to specify default parameters in later PR(s).
Library::loadxmldata()has not completely been moved as there are some cases which cannot be changed (yet).