Suppressions: some cleanups - #4980
Merged
Merged
Conversation
Suppressions::isSuppressed() codeSuppressions cleanups
firewave
force-pushed
the
suppr-local
branch
2 times, most recently
from
May 4, 2023 09:43
c578983 to
f353112
Compare
firewave
marked this pull request as ready for review
May 4, 2023 09:43
danmar
approved these changes
May 4, 2023
…or `Suppressions::Suppression` - fixes `performance-move-const-arg` clang-tidy warning
danmar
approved these changes
May 4, 2023
Collaborator
Author
|
The clang-tidy warning which lead to the removal of the copy/assignment constructor was actually a bit misleading as it implied I tried to move an object where I cannot move it to. I filed llvm/llvm-project#62550 upstream about clarifying the message. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.