Skip to content

SingleExecutor: process markup files after code when scanning projects#4972

Merged
firewave merged 8 commits into
cppcheck-opensource:mainfrom
firewave:single-markup
May 3, 2023
Merged

SingleExecutor: process markup files after code when scanning projects#4972
firewave merged 8 commits into
cppcheck-opensource:mainfrom
firewave:single-markup

Conversation

@firewave
Copy link
Copy Markdown
Collaborator

No description provided.

@firewave
Copy link
Copy Markdown
Collaborator Author

I did not get rid of the redundant code in SingleExecutor::check() because after all the TODOs have been fixed and the executors are aligned and use the shared code it should have been implicitly fixed.

I will also fix up the SingleExecutor before I start applying the fixes to the other executors.

@firewave firewave marked this pull request as draft April 16, 2023 17:40
@firewave
Copy link
Copy Markdown
Collaborator Author

The tests fail because they are run in parallel and use the same file names. I will try to come up with something that provides incremental files names with a unique base.

@firewave
Copy link
Copy Markdown
Collaborator Author

The tests fail because they are run in parallel and use the same file names. I will try to come up with something that provides incremental files names with a unique base.

They only consistently fail on MacOS with CMake. If my assumption was true they should fail randomly for any CMake build. So there might be another issue at bay here.

@firewave firewave changed the title SingleExecutor: process markup files after code with file settings SingleExecutor: process markup files after code when scanning project Apr 18, 2023
@firewave
Copy link
Copy Markdown
Collaborator Author

Turns out the tests were interfering with each other so I add a cost to one of them so they don't run at the same time.

I first thought I might have hit UB since I was modifying an object after it was const referenced but I never hit that code. I fixed it anyways.

@firewave firewave force-pushed the single-markup branch 2 times, most recently from cdde6bd to 798292a Compare April 18, 2023 10:57
@firewave firewave marked this pull request as ready for review April 18, 2023 10:57
@firewave firewave changed the title SingleExecutor: process markup files after code when scanning project SingleExecutor: process markup files after code when scanning projects Apr 18, 2023
Comment thread releasenotes.txt
@danmar
Copy link
Copy Markdown
Collaborator

danmar commented Apr 22, 2023

It seems we have broken the support for qml files

So I would suggest that we fix it first.. see #5001

@firewave firewave merged commit b5ce2c7 into cppcheck-opensource:main May 3, 2023
@firewave firewave deleted the single-markup branch May 3, 2023 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants