Improve handling of 'final' in class declaration#4706
Merged
Conversation
danmar
reviewed
Jan 14, 2023
| // 1) struct name final { }; <- struct is final | ||
| if (Token::Match(tok->previous(), "struct|class|union %type%")) { | ||
| Token* finalTok = tok->next(); | ||
| if (tok->isUpperCaseName() && Token::Match(finalTok, "%type%") && finalTok->str() != "final") { |
Collaborator
There was a problem hiding this comment.
hmm.. this is a guessing game.. theoretically I think your guess could go wrong in such code:
class C FINAL {};
Could we try to bailout if we are unsure?
You could make this check more explicit. You could check that finalTok is not uppercase. Or how about Token::Match(finalTok, "%type% final")
Collaborator
Author
There was a problem hiding this comment.
class C FINAL {}; gives test.cpp:1:1: information: The code 'class C FINAL {' is not handled. You can use -I or --include to add handling of this code. [class_X_Y] even without this change.
We cannot bail out in the tokenizer, since it might be a valid variable declaration, see https://github.com/danmar/cppcheck/actions/runs/3920131345/jobs/6701567873
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.