Skip to content

Update version check in ccache.cmake so ccache can work on older cmake versions #4567

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
firewave merged 3 commits into from
Nov 14, 2022
Merged

Update version check in ccache.cmake so ccache can work on older cmake versions #4567

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
22301d4
Remove ccache.cmake so ccache can work on older cmake versions
pfultz2 Oct 27, 2022
acd4faa
Revert "Remove ccache.cmake so ccache can work on older cmake versions"
pfultz2 Nov 13, 2022
57aa683
Update version
pfultz2 Nov 13, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion cmake/ccache.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
if (CMAKE_VERSION VERSION_LESS "3.17")
Copy link
Copy Markdown
Collaborator

@firewave firewave Oct 29, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please restore this file and change the version to check for to 3.0.

Copy link
Copy Markdown
Contributor Author

@pfultz2 pfultz2 Nov 13, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

if (CMAKE_VERSION VERSION_LESS "3.0")
if (CMAKE_CXX_COMPILER_LAUNCHER)
set_property(GLOBAL PROPERTY RULE_LAUNCH_COMPILE "${CMAKE_CXX_COMPILER_LAUNCHER}")
elseif (CMAKE_C_COMPILER_LAUNCHER)
Expand Down