Skip to content

Library Data: Add support for optional smart pointer element 'unique'#4132

Merged
danmar merged 5 commits into
cppcheck-opensource:mainfrom
matzeschmid:fix-LibraryData-SmartPointer-unique-element
Jul 4, 2022
Merged

Library Data: Add support for optional smart pointer element 'unique'#4132
danmar merged 5 commits into
cppcheck-opensource:mainfrom
matzeschmid:fix-LibraryData-SmartPointer-unique-element

Conversation

@matzeschmid

Copy link
Copy Markdown
Contributor

Avoid configuration load failure due to unhandled element (e.g. qt.cfg).
Avoid data loss during configuration save.
Update smart pointer test.

@firewave

Copy link
Copy Markdown
Collaborator

See https://trac.cppcheck.net/ticket/10687 for a ticket which includes this.

@matzeschmid

matzeschmid commented Jul 4, 2022

Copy link
Copy Markdown
Contributor Author

Latest commits will fix library editor load issues for existing configuration files and thus should provide a fix for trac ticket listed in previous comment too. Note: Current PR subject/title doesn't reflect all changes.

@danmar
danmar merged commit c897c04 into cppcheck-opensource:main Jul 4, 2022
@firewave

firewave commented Jul 5, 2022

Copy link
Copy Markdown
Collaborator

Latest commits will fix library editor load issues for existing configuration files and thus should provide a fix for trac ticket listed in previous comment too

That's awesome. I just posted it as a reference not as an invitation to fix it all ;-) Thanks.

It would be great if there were a test which loads all our cfg files to prevent this from breaking in the future. I had to check those files manually.

Note: Current PR subject/title doesn't reflect all changes.

You can edit the title.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants