Fix #10682 Unused QString / #10686 unused std::array / #10005 unused variable with c++11 braced initializer not detected by chrchr-github · Pull Request #3684 · cppcheck-opensource/cppcheck

chrchr-github · 2022-01-07T18:01:00Z

No description provided.

firewave · 2022-01-07T18:50:29Z

As mentioned in the ticket I assumed other containers might also be affected. And QMap, QSet, QMultiMap and QQueue are somehow not detected. QList and QVector are. There's probably more but I just looked at the STL counterparts.

#include <map>
#include <list>
#include <array>
#include <vector>
#include <set>
#include <queue>
#include <deque>
#include <forward_list>
#include <unordered_set>
#include <unordered_map>

#include <QMap>
#include <QList>
#include <QVector>
#include <QSet>
#include <QMultiMap>
#include <QQueue>

extern void f()
{
	std::map<int, int> m;
	QMap<int, int> qm;

	std::list<int> l;
	QList<int> ql;

	std::array<int, 1> a;

	std::vector<int> v;
	QVector<int> qv;

	std::set<int> s;
	QSet<int> qs;

	std::multimap<int, int> mm;
	QMultiMap<int, int> qmm;

	std::multiset<int> ms;

	std::queue<int> q;
	QQueue<int> qq;

	std::deque<int> d;

	std::forward_list<int> fl;

	std::unordered_set<int> us;

	std::unordered_map<int, int> um;
}

/mnt/s/clion/example_lite_2/test.cpp:21:21: style: Unused variable: m [unusedVariable]
 std::map<int, int> m;
                    ^
/mnt/s/clion/example_lite_2/test.cpp:24:17: style: Unused variable: l [unusedVariable]
 std::list<int> l;
                ^
/mnt/s/clion/example_lite_2/test.cpp:25:13: style: Unused variable: ql [unusedVariable]
 QList<int> ql;
            ^
/mnt/s/clion/example_lite_2/test.cpp:29:19: style: Unused variable: v [unusedVariable]
 std::vector<int> v;
                  ^
/mnt/s/clion/example_lite_2/test.cpp:30:15: style: Unused variable: qv [unusedVariable]
 QVector<int> qv;
              ^
/mnt/s/clion/example_lite_2/test.cpp:32:16: style: Unused variable: s [unusedVariable]
 std::set<int> s;
               ^
/mnt/s/clion/example_lite_2/test.cpp:35:26: style: Unused variable: mm [unusedVariable]
 std::multimap<int, int> mm;
                         ^
/mnt/s/clion/example_lite_2/test.cpp:38:21: style: Unused variable: ms [unusedVariable]
 std::multiset<int> ms;
                    ^
/mnt/s/clion/example_lite_2/test.cpp:40:18: style: Unused variable: q [unusedVariable]
 std::queue<int> q;
                 ^
/mnt/s/clion/example_lite_2/test.cpp:43:18: style: Unused variable: d [unusedVariable]
 std::deque<int> d;
                 ^
/mnt/s/clion/example_lite_2/test.cpp:45:25: style: Unused variable: fl [unusedVariable]
 std::forward_list<int> fl;
                        ^
/mnt/s/clion/example_lite_2/test.cpp:47:26: style: Unused variable: us [unusedVariable]
 std::unordered_set<int> us;
                         ^
/mnt/s/clion/example_lite_2/test.cpp:49:31: style: Unused variable: um [unusedVariable]
 std::unordered_map<int, int> um;
                              ^

std::array also isn't detected but I will add another ticket for that.

firewave · 2022-01-07T18:55:27Z

        for (const QString &tag: tags) {
            xmlWriter.writeStartElement(CppcheckXml::TagWarningsElementName);
            xmlWriter.writeAttribute(CppcheckXml::TagAttributeName, tag);
-            QStringList warnings;


chrchr-github · 2022-01-07T19:00:31Z

It seems that those containers are missing from qt.cfg (QMap, QMultiMap, QSet, QQueue).

firewave · 2022-01-07T19:13:26Z

It seems that those containers are missing from qt.cfg (QMap, QMultiMap, QSet, QQueue).

Ah - I didn't check that. I will add a ticket for that.

firewave · 2022-01-07T22:40:56Z

Nice. 😀 Better change the title so we know there's two tickets in this PR.

Add suppression

firewave · 2022-01-08T11:11:50Z

https://trac.cppcheck.net/ticket/10005 is the ticket for the undetected unused braced initializer variables.

This is becoming a grand slam.🥳

firewave · 2022-01-08T11:28:50Z

Here's some similar tickets you might also want to have a look at after this:
https://trac.cppcheck.net/ticket/7732 - looks related to having a constructor being used
https://trac.cppcheck.net/ticket/10057 - looks related to missing varid

chrchr-github · 2022-01-08T11:47:30Z

Here's some similar tickets you might also want to have a look at after this: https://trac.cppcheck.net/ticket/7732 - looks related to having a constructor being used https://trac.cppcheck.net/ticket/10057 - looks related to missing varid

It never ends, does it? 🤪

firewave · 2022-01-08T12:14:19Z

It never ends, does it? 🤪

With these changes we're a lot closer. 🐱‍👤 And this should probably end here.

There's also the side effect shortcomings 😏 But "might" and "after this"!

orbitcowboy · 2022-01-11T08:16:46Z

Here's some similar tickets you might also want to have a look at after this: https://trac.cppcheck.net/ticket/7732 - looks related to having a constructor being used https://trac.cppcheck.net/ticket/10057 - looks related to missing varid

It never ends, does it? zany_face

It never ends, that's true, I found other cases:

void f(void)
{
	int();
	int(1);
	int{};
	int{1};
}

$ gcc -c test1.cpp && cppcheck --enable=all test1.cpp 
Checking test1.cpp ...
test1.cpp:4:0: style: The function 'f' is never used. [unusedFunction]

^
nofile:0:0: information: Cppcheck cannot find all the include files (use --check-config for details) [missingIncludeSystem]

firewave · 2022-01-11T09:37:06Z

It never ends, that's true, I found other cases:

That's https://trac.cppcheck.net/ticket/10057.

chrchr-github added 2 commits January 7, 2022 18:38

Add variables that are library containers

5d92690

Remove unused variable

7533de3

firewave reviewed Jan 7, 2022

View reviewed changes

Fix #10686 unused std::array not detected

04b7a1f

chrchr-github changed the title ~~Fix #10682 False negative: Unused QString variable is not detected~~ Fix #10682 False negative: Unused QString not detected / #10686 unused std::array not detected Jan 7, 2022

chrchr-github and others added 3 commits January 8, 2022 02:41

Unused variables with bace-init

b56cb67

Merge branch 'danmar:main' into chr_Fix10682

f4adc73

Update qt.cpp

e37a989

Add suppression

chrchr-github changed the title ~~Fix #10682 False negative: Unused QString not detected / #10686 unused std::array not detected~~ Fix #10682 Unused QString / #10686 unused std::array / #10005 unused variable with c++11 braced initializer not detected Jan 8, 2022

danmar merged commit df3da38 into cppcheck-opensource:main Jan 10, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix #10682 Unused QString / #10686 unused std::array / #10005 unused variable with c++11 braced initializer not detected#3684

Fix #10682 Unused QString / #10686 unused std::array / #10005 unused variable with c++11 braced initializer not detected#3684
danmar merged 6 commits into
cppcheck-opensource:mainfrom
chrchr-github:chr_Fix10682

chrchr-github commented Jan 7, 2022

Uh oh!

firewave commented Jan 7, 2022 •

edited

Loading

Uh oh!

firewave Jan 7, 2022

Uh oh!

chrchr-github commented Jan 7, 2022 •

edited

Loading

Uh oh!

firewave commented Jan 7, 2022

Uh oh!

firewave commented Jan 7, 2022

Uh oh!

firewave commented Jan 8, 2022

Uh oh!

firewave commented Jan 8, 2022

Uh oh!

chrchr-github commented Jan 8, 2022

Uh oh!

firewave commented Jan 8, 2022

Uh oh!

orbitcowboy commented Jan 11, 2022 •

edited

Loading

Uh oh!

firewave commented Jan 11, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

chrchr-github commented Jan 7, 2022

Uh oh!

firewave commented Jan 7, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

firewave Jan 7, 2022

Choose a reason for hiding this comment

Uh oh!

chrchr-github commented Jan 7, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

firewave commented Jan 7, 2022

Uh oh!

firewave commented Jan 7, 2022

Uh oh!

firewave commented Jan 8, 2022

Uh oh!

firewave commented Jan 8, 2022

Uh oh!

chrchr-github commented Jan 8, 2022

Uh oh!

firewave commented Jan 8, 2022

Uh oh!

orbitcowboy commented Jan 11, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

firewave commented Jan 11, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

firewave commented Jan 7, 2022 •

edited

Loading

chrchr-github commented Jan 7, 2022 •

edited

Loading

orbitcowboy commented Jan 11, 2022 •

edited

Loading