fixed some unusedFunction warnings#3618
Conversation
|
CLion does find a lot more unused code and I will try to add false negative tickets for those. |
danmar
left a comment
There was a problem hiding this comment.
nice work! let's try the readingEmptyStlContainer2 maybe.
| std::cout << stringifyList(stringifyOptions::forPrintOut(), &fileNames, nullptr) << std::endl; | ||
| } | ||
|
|
||
| void Token::printLines(int lines) const |
There was a problem hiding this comment.
I had forgot about Token::printLines. I've always used Token::printOut during debugging but this looks more useful. Let's keep this.
There was a problem hiding this comment.
We should annotate this then with the unused/maybe_unused attribute - or a suppression if we do not support that yet.
|
Some need to be bisected for when the usage was dropped or if it ever existed. |
|
8a59c05 to
734618e
Compare
734618e to
7693579
Compare
|
I restored some of the obvious helper functions for now so this can be merged. We can tackle these at a later date. |
| * preprocess all whitespaces | ||
| * @param processedFile The data to be processed | ||
| */ | ||
| static void preprocessWhitespaces(std::string &processedFile); |
There was a problem hiding this comment.
The usage was removed in 3432257 - leftover code from removed feature so it can be deleted.
|
The build failure was a download failure. This can be reduced by merging #3612. |
|
This can be merged. All other things related to this will be resolved when the CI job for this is being added. |
These were detected by running a self check with
--enable=unusedFunction. I will file tickets for the false positives at a later date.