added 32-bit Windows build to GitHub action#3144
Conversation
…bit Qt binaries are available / rewrite "x86" to "Win32" for solution builds / switched PCRE to NMake for easier build
danmar
left a comment
There was a problem hiding this comment.
I think this looks good to merge I just have a question.
|
|
||
| - name: Run Release test | ||
| run: .\bin\testrunner.exe | ||
| run: .\bin\testrunner.exe || exit /b !errorlevel! |
There was a problem hiding this comment.
what does this exit accomplish? if testrunner succeed why do we need that extra stuff..
There was a problem hiding this comment.
I wasn't sure if the last %ERRORLEVEL% in a batch script is propagated to the caller. I just tested it and if there is just a single command we don't need to do this. Actually we don't need to do it for the last one either but in case someone extends the steps he might miss adding it. So I think it would be fine to keep it.
There was a problem hiding this comment.
hmm.. so you are saying that if there are two commands and the first fail and the second succeed.. then this script will succeed. that was unexpected imho. I'd expect an immediate abort.
There was a problem hiding this comment.
A bash script behaves the same unless you specify set -e in it. Batch scripts unfortunately do not have such a "fail all" option.
There was a problem hiding this comment.
I don't know if this is a batch script. We use https://docs.github.com/en/actions/reference/workflow-syntax-for-github-actions#jobsjob_idstrategyfail-fast right?
There was a problem hiding this comment.
It definitely is.
fail-fast has nothing to do with the steps but with the jobs. So in this if the x86 build fails it will immediately cancel the x64 one as well.
There was a problem hiding this comment.
hmm ok.. thanks for the clarification. I am surprised that this CI script might not fail when a step is failing..
No description provided.