Refactor valueFlowTerminatingCondition to handle inner conditions and complex conditions#3060
Merged
danmar merged 8 commits intoJan 21, 2021
Conversation
danmar
reviewed
Jan 19, 2021
| } | ||
|
|
||
| static void valueFlowTerminatingCondition(TokenList *tokenlist, SymbolDatabase* symboldatabase, ErrorLogger *errorLogger, const Settings *settings) | ||
| ValueFlow::Value MakeConditionValue(long long val, const Token* condTok, bool assume) |
| "test.cpp:2:note:'y' is assigned value 'x' here.\n" | ||
| "test.cpp:3:note:first condition\n" | ||
| "test.cpp:4:note:else if condition is opposite to first condition\n", errout.str()); | ||
| ASSERT_EQUALS("test.cpp:4:style:Condition '!y' is always true\n" |
Collaborator
There was a problem hiding this comment.
the old warning was much easier to read. I do not expect that a user will always understand why cppcheck thinks that conditions are always true/false. The real world cases will not be obvious.
danmar
reviewed
Jan 21, 2021
| " else { if (a == 2) { b = 3; } } }\n" | ||
| "}"); | ||
| ASSERT_EQUALS("[test.cpp:3] -> [test.cpp:4]: (style) Condition 'a==2' is always false\n", errout.str()); | ||
| ASSERT_EQUALS("[test.cpp:4]: (style) Expression is always false because 'else if' condition matches previous condition at line 3.\n", errout.str()); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.