Fix false positive AssignmentIntegerToAddress#2971
Merged
danmar merged 2 commits intoDec 24, 2020
Conversation
Due to a issue while parsing the function declaration (we ended up with
the type of the first argument instead of the return type).
```
c.cpp:6:11: portability: Assigning an integer to a pointer is not portable. [AssignmentIntegerToAddress]
Array a = f(i);
^
```
typedef std::array<int, 2> Array;
Array f(int i);
int g(int i) {
Array a = f(i);
return 2;
}
```
danmar
approved these changes
Dec 23, 2020
Collaborator
danmar
left a comment
There was a problem hiding this comment.
Looks good! If you remove the if I pointed out I feel this can be merged.
| // 1 scopes: Global | ||
| ASSERT(db && db->scopeList.size() == 1); | ||
|
|
||
| if (db) { |
Collaborator
There was a problem hiding this comment.
Such if was needed until 2-3 years ago. Nowadays an ASSERT will stop the test if the condition is false. So please remove this redundant if.
Contributor
Author
There was a problem hiding this comment.
I took the opportunity to clean the whole file.
23e903c to
3ddc36c
Compare
3ddc36c to
ad74ea2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Due to a issue while parsing the function declaration (we ended up with
the type of the first argument instead of the return type).
typedef std::array<int, 2> Array;
Array f(int i);
int g(int i) {
Array a = f(i);
return 2;
}