Remove ./ from relative paths in online-help.qhp#2860
Merged
danmar merged 1 commit intoOct 26, 2020
Merged
Conversation
- Fixes the following errors, when opening online-help.qhc using Qt
assistant: QTextBrowser: No document for
qthelp://cppcheck.sourceforge.net/doc/./preferences.html
etc.
- Furthermore, ./ is not used anymore in Qt documentation:
https://doc.qt.io/qt-5/qtassistant-simpletextviewer-example.html
It was used previously:
https://doc.qt.io/archives/qt-4.8/qt-help-simpletextviewer-example.html
Example:
<section title="Find File" ref="./findfile.html">
->
<section title="Find File" ref="findfile.html">
Contributor
Author
|
How to reproduce: cd gui/help/
qhelpgenerator online-help.qhcp -o online-help.qhc
# View the generated online-help.qhc file using Qt assistant
assistant -collectionFile online-help.qhc
# Click on Contents - Cppcheck GUI Help - Preferences
# Output on Linux terminal:
QTextBrowser: No document for qthelp://cppcheck.sourceforge.net/doc/./preferences.htmlTested with: Qt 5.15.1 |
Collaborator
|
I somehow have the feeling that I needed this before. But I merged this for now.. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
online-help.qhcusing Qtassistant:
QTextBrowser: No document for qthelp://cppcheck.sourceforge.net/doc/./preferences.htmlhttps://doc.qt.io/qt-5/qtassistant-simpletextviewer-example.html
It was used previously:
https://doc.qt.io/archives/qt-4.8/qt-help-simpletextviewer-example.html
Example:
<section title="Find File" ref="./findfile.html">->
<section title="Find File" ref="findfile.html">