fixed some modernize-loop-convert clang-tidy warnings#2815
Merged
Conversation
d9c0107 to
3d3d703
Compare
3d3d703 to
98b6238
Compare
Collaborator
Author
|
I accidentally force-pushed an empty branch and it auto-closed the ticket. When I pushed the proper changes it failed to invoke the build again. So it needs to be triggered manually. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I did not convert the loops with
const_iteratorsince the range loops do not ensure the constness. That's also the reason I didn't enable the warning yet.