Check specific Visual Studio configurations by fuzzelhjb · Pull Request #2503 · cppcheck-opensource/cppcheck

fuzzelhjb · 2020-01-24T12:54:05Z

Add support to check against selected Visual Studio configurations in a cppcheck project file.
The cppcheck project file format was extended with a potential list of VS configurations. On importing a Visual Studio solution or project file from a .cppcheck file only those configurations that match the ones in the list are checked.

…he project file

danmar

thanks. this is probably 95% good.

I think I need to build and test it..

danmar · 2020-01-25T09:10:37Z

    const char MaxCtuDepthElementName[] = "max-ctu-depth";
    const char CheckUnknownFunctionReturn[] = "check-unknown-function-return-values";
    const char Name[] = "name";
+    const char VSConfigurationElementName[] = "vsconfigurations";


The variable names are fine. But the xml elements normally use "-" to separate names. So maybe "vs-configurations" and "config" are good names.

fuzzelhjb · 2020-01-25T09:13:06Z

Ok I'll update the names. Daniel Marjamäki <notifications@github.com> schrieb am Sa., 25. Jan. 2020, 10:11:

…

***@***.**** commented on this pull request. thanks. this is probably 95% good. I think I need to build and test it.. ------------------------------ In lib/importproject.h <#2503 (comment)>: > @@ -153,6 +154,8 @@ namespace CppcheckXml { const char MaxCtuDepthElementName[] = "max-ctu-depth"; const char CheckUnknownFunctionReturn[] = "check-unknown-function-return-values"; const char Name[] = "name"; + const char VSConfigurationElementName[] = "vsconfigurations"; The variable names are fine. But the xml elements normally use "-" to separate names. So maybe "vs-configurations" and "config" are good names. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#2503>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAQTYQY4KFJ4PLZSF7NIH43Q7P64ZANCNFSM4KLFXBNA> .

…k_specific_VS_config

danmar · 2020-01-26T07:49:33Z

I assume this technically is working but maybe the UI can be tweaked.

For me it is confusing what happens if I both click on "Analyze all visual studio solutions" and write something in the edit box. If "analyze all visual studio solutions" is checked I suggest that the editbox is disabled.

Somehow it would be good if the available configurations is listed. Do you want to be able to analyze several configurations but not all? If you are fine analyzing 1 configuration then a combobox could be used.

…k_specific_VS_config

…jb/cppcheck into check_specific_VS_config

fuzzelhjb · 2020-01-27T13:44:27Z

I changed the behavior as suggested. If you select "Analyze all visual studio configurations" then the textbox is disabled. I think it would be nice to define multiple configurations so a semicolon separated list would make more sense here.
Afaik the UI doesn't read the actual vcxproj/sln file so there is no way to list all configurations in the textbox.

danmar · 2020-01-28T05:59:43Z

Afaik the UI doesn't read the actual vcxproj/sln file so there is no way to list all configurations in the textbox.

That is true. But that would be pretty simple to add.

#include "importproject.h"

Then create a utility function like:

static QStringList getProjectConfigs(QString fileName) {
    QStringList ret;
    ImportProject importer;
    importer.load(fileName.toStdString());
    for (const std::string &cfg : importer.getConfigs())
        ret << QString::fromStdString(cfg);
    return ret;
}

And then in ImportProject we need a function getConfigs()... I am sure you can put that together.

I have the feeling that it's more difficult to tweak the GUI. In my head I would like that the user could select configurations somehow. It would be very easy to miswrite a configuration if they are not listed or checked at all. What happens then, Cppcheck will not write any warning? And can't the configurations contain semicolon also?

danmar · 2020-01-28T06:06:14Z

I am grateful that you are working on this. It will be a really cool enhancement!

…k_specific_VS_config

fuzzelhjb · 2020-01-28T14:26:54Z

You're welcome :) I updated the importer to automatically read all different configurations. The UI was updated too. I replaced the textbox with a QListWidget so the user can multi-select configurations

…jb/cppcheck into check_specific_VS_config

danmar · 2020-01-28T17:55:45Z

-                        if (p.platform != ProjectConfiguration::Unknown)
+                        if (p.platform != ProjectConfiguration::Unknown) {
                            projectConfigurationList.emplace_back(cfg);
+                            bool alreadyIn = false;


hmm.. I envisioned that this would be kept out of importVcxproj.

std::set<std::string> ImportProject::getVSConfigs() const { std::set<std::string> ret; for (const FileSettings &fs: fileSettings) ret.insert(fs.cfg); return ret; }

danmar · 2020-01-28T17:59:13Z

The UI was updated too. I replaced the textbox with a QListWidget so the user can multi-select configurations

Cool.. will take a look soon

danmar · 2020-01-31T06:12:19Z

I merged this, it works good enough for merge. But I think you can tweak it better.

When I did not have a vcxproj/sln and chose a sln, both the checkbox and the listbox was enabled.
When I remove the vcxproj/sln from the editbox then the list box is not cleared.

fuzzelhjb · 2020-01-31T07:10:51Z

I created a new PR with some tiny fixed that should fix this.

fuzzelhjb added 2 commits January 24, 2020 13:05

add support for selected Visual Studio configurations in the UI and t…

6f75b17

…he project file

skip VS configurations that don't match the one in the project file

a65cb9a

danmar reviewed Jan 25, 2020

View reviewed changes

fuzzelhjb added 2 commits January 25, 2020 11:09

Merge branch 'master' of https://github.com/danmar/cppcheck into chec…

ea3b2bf

…k_specific_VS_config

rename xml tags

491045e

fuzzelhjb and others added 4 commits January 26, 2020 16:34

Merge branch 'master' of https://github.com/danmar/cppcheck into chec…

c685eb5

…k_specific_VS_config

Merge branch 'master' of https://github.com/danmar/cppcheck into chec…

e74eae9

…k_specific_VS_config

disable selected VS config textbox if all VS configs should be analyzed

de704f5

Merge branch 'check_specific_VS_config' of https://github.com/fuzzelh…

47e9162

…jb/cppcheck into check_specific_VS_config

fuzzelhjb added 3 commits January 28, 2020 13:01

Merge branch 'master' of https://github.com/danmar/cppcheck into chec…

d7fdfec

…k_specific_VS_config

on importing a VS project/solution also read all configurations

11dff91

add QListWidget for VS configurations

b9e8af7

Merge branch 'check_specific_VS_config' of https://github.com/fuzzelh…

96a1d0a

…jb/cppcheck into check_specific_VS_config

danmar reviewed Jan 28, 2020

View reviewed changes

fuzzelhjb and others added 2 commits January 28, 2020 20:11

auto select these configs that were loaded from the cppcheck file

bbbb220

Merge branch 'master' into check_specific_VS_config

f0efdb9

danmar merged commit 074d08e into cppcheck-opensource:master Jan 31, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Check specific Visual Studio configurations#2503

Check specific Visual Studio configurations#2503
danmar merged 14 commits into
cppcheck-opensource:masterfrom
fuzzelhjb:check_specific_VS_config

fuzzelhjb commented Jan 24, 2020

Uh oh!

danmar left a comment

Uh oh!

danmar Jan 25, 2020

Uh oh!

fuzzelhjb commented Jan 25, 2020 via email

Uh oh!

danmar commented Jan 26, 2020

Uh oh!

fuzzelhjb commented Jan 27, 2020

Uh oh!

danmar commented Jan 28, 2020 •

edited

Loading

Uh oh!

danmar commented Jan 28, 2020

Uh oh!

fuzzelhjb commented Jan 28, 2020

Uh oh!

danmar Jan 28, 2020 •

edited

Loading

Uh oh!

danmar commented Jan 28, 2020

Uh oh!

danmar commented Jan 31, 2020

Uh oh!

fuzzelhjb commented Jan 31, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

fuzzelhjb commented Jan 24, 2020

Uh oh!

danmar left a comment

Choose a reason for hiding this comment

Uh oh!

danmar Jan 25, 2020

Choose a reason for hiding this comment

Uh oh!

fuzzelhjb commented Jan 25, 2020 via email

Uh oh!

danmar commented Jan 26, 2020

Uh oh!

fuzzelhjb commented Jan 27, 2020

Uh oh!

danmar commented Jan 28, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

danmar commented Jan 28, 2020

Uh oh!

fuzzelhjb commented Jan 28, 2020

Uh oh!

danmar Jan 28, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

danmar commented Jan 28, 2020

Uh oh!

danmar commented Jan 31, 2020

Uh oh!

fuzzelhjb commented Jan 31, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

danmar commented Jan 28, 2020 •

edited

Loading

danmar Jan 28, 2020 •

edited

Loading