Fix #9501: htmlreport: Line number position is shifted#2480
Merged
amai2012 merged 1 commit intoJan 9, 2020
Merged
Conversation
The 1 pixel dotted border that is drawn around every Cppcheck error message adds 2 extra pixels for every line with an error message. For more than very few error messages in a file the discrepancy is clearly visible and line numbering gets wrong. This commit removes the dotted border as it is not necessary. The error message is highlighted with a red background and is still clearly visible.
versat
added a commit
to versat/cppcheck
that referenced
this pull request
Jan 13, 2020
…source#2480) The 1 pixel dotted border that is drawn around every Cppcheck error message adds 2 extra pixels for every line with an error message. For more than very few error messages in a file the discrepancy is clearly visible and line numbering gets wrong. This commit removes the dotted border as it is not necessary. The error message is highlighted with a red background and is still clearly visible.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The 1 pixel dotted border that is drawn around every Cppcheck error
message adds 2 extra pixels for every line with an error message.
For more than very few error messages in a file, the discrepancy is
clearly visible and line numbering gets wrong.
This commit removes the dotted border as it is not necessary.
The error message is highlighted with a red background and is still
clearly visible.
Ticket: https://trac.cppcheck.net/ticket/9501