Fix #9383 ("debug: Function::addArguments found argument 'x' with var…#2238
Merged
Conversation
…id 0." with variadic templates)
amai2012
reviewed
Oct 5, 2019
| } else if (tok2->str() == "::") { | ||
| singleNameCount = 0; | ||
| } else if (tok2->str() != "*" && tok2->str() != "::") { | ||
| } else if (tok2->str() != "*" && tok2->str() != "::" && tok2->str() != "...") { |
Collaborator
There was a problem hiding this comment.
Will thie be executed for C code as well?
Contributor
Author
There was a problem hiding this comment.
Yes but it is already checking for "::" in a few places without checking the language. Should they all be fixed?
Collaborator
There was a problem hiding this comment.
I believe that we don't need special handling of C code for ::.. valid C code does not contain that operator.
But ... can be used in C code. However if there is valid C code that contains ... I would assume that should be handled the same way in C++ mode... so this either does not break C or it breaks both C and C++ parsing.
jubnzv
pushed a commit
to jubnzv/cppcheck
that referenced
this pull request
Nov 13, 2019
…id 0." with variadic templates) (cppcheck-opensource#2238)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…id 0." with variadic templates)