Skip to content

misra.py: Add R18.7 check #1934

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
danmar merged 4 commits into from
Jul 1, 2019
Merged

misra.py: Add R18.7 check #1934

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
ab840bd
misra.py: Add 18.7 check
jubnzv Jun 29, 2019
adeaf9b
Simplify R18.7 check
jubnzv Jun 30, 2019
e87b61a
use token.link
jubnzv Jun 30, 2019
b1f3287
Remove isStruct method
jubnzv Jul 1, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 19 additions & 0 deletions addons/misra.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1628,6 +1628,24 @@ def misra_18_5(self, data):
self.reportError(var.nameToken, 18, 5)


def misra_18_7(self, data):
for scope in data.scopes:
if scope.type != 'Struct':
continue

token = scope.bodyStart.next
while token != scope.bodyEnd and token is not None:
# Handle nested structures to not duplicate an error.
if token.str == '{':
token = token.link

if cppcheckdata.simpleMatch(token, "[ ]"):
self.reportError(token, 18, 7)
break
token = token.next



def misra_18_8(self, data):
for var in data.variables:
if not var.isArray or not var.isLocal:
Expand Down Expand Up @@ -2287,6 +2305,7 @@ def parseDump(self, dumpfile):
self.misra_17_7(cfg)
self.misra_17_8(cfg)
self.misra_18_5(cfg)
self.misra_18_7(cfg)
self.misra_18_8(cfg)
self.misra_19_2(cfg)
self.misra_20_1(cfg)
Expand Down
19 changes: 19 additions & 0 deletions addons/test/misra-test.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -507,6 +507,25 @@ void misra_18_5() {
int *** p; // 18.5
}

struct {
uint16_t len;
struct {
uint8_t data_1[]; // 18.7
} nested_1;
struct named {
struct {
uint8_t len_1;
uint32_t data_2[]; // 18.7
} nested_2;
uint8_t data_3[]; // 18.7
} nested_3;
} _18_7_struct;
struct {
uint16_t len;
uint8_t data_1[ 19 ];
uint8_t data_2[ ]; // 18.7
} _18_7_struct;

void misra_18_8(int x) {
int buf1[10];
int buf2[sizeof(int)];
Expand Down