runastyle: Fix wildcard expansion happening too soon#1650
Merged
Conversation
At least under Windows with Cygwin i see a problem. For lines like `formatCplusplus lib/*.cpp` the wildcard is replaced by ONE filename before the function is called. This results in only one file being formatted in the corresponding directory. The fix seems quite simple. Just use quotes for all function parameters like this: `formatCplusplus "lib/*.cpp"` The wildcard is preserved and only extended in the function body, so all matching files get formatted.
versat
referenced
this pull request
Feb 7, 2019
Collaborator
|
Yes, thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
At least under Windows with Cygwin i see a problem.
For lines like
formatCplusplus lib/*.cppthe wildcard is replaced by ONE filename before the function is called.This results in only one file being formatted in the corresponding directory.
The fix seems quite simple. Just use quotes for all function parameters like this:
formatCplusplus "lib/*.cpp"The wildcard is preserved and only expanded in the function body, so all matching files get formatted.