Skip to content

Fix per file excludes#1437

Merged
danmar merged 5 commits into
cppcheck-opensource:masterfrom
whoopsmith:fix_per_file_excludes
Oct 18, 2018
Merged

Fix per file excludes#1437
danmar merged 5 commits into
cppcheck-opensource:masterfrom
whoopsmith:fix_per_file_excludes

Conversation

@whoopsmith
Copy link
Copy Markdown
Contributor

@danmar More testing found a few issues with the per-file suppressions.

@orbitcowboy I added new test files that allow for the testing of various forms of suppression.

--show-suppressed-rules will print rules in the suppression rule list to
the console sorted by rule number.
The entire file scope suppression check was checking for the rule item
list to be None instead of looking for None as an entry into the list.

Correct this check and modify the documentation to explicitly state that
an entry of None in the rule item list will set the scope for that
suppression to be the entire file.
To run:

../../cppcheck --suppressions-list=suppressions.txt --dump misra-suppressions*-test.c
python ../misra.py misra-suppressions*-test.c.dump

There should be no violations reported
For environments that run cppcheck from the build system cppcheck may be
passed a filename that is a complete path.

Often this path will include a portion that is specific to the developer
or to the environment where the project is located.

The per-file suppression rules do filename matching based on the
filename passed to cppcheck. To match any path information also has to
be included into the suppressions file provided to cppcheck via the
--suppressions-list= option.

This limits the usefulness of the per-file based suppressions because
it requires the suppression to be customized on a per instance basis.

Add a option "--file-prefix" that allows a prefix to be excluded from
the file path when doing the suppression filename matching.

Example.

Given the following structure:

/test/path1/misra-suppressions1-test.c
/test/path1/misra-suppressions2-test.c

specifying --file-prefix /test/path1 will allow the use of
misra-suppressions1-test.c and misra-suppressions2-test.c as filenames
in the suppressions file without leading patch information but still
match the suppression rule.
To run:

../../cppcheck --suppressions-list=suppressions.txt \
    --dump misra-suppressions*-test.c \
           path1/misra-suppressions*-test.c

python ../misra.py misra-suppressions*-test.c.dump \
                   path1/misra-suppressions*-test.c

There should be no violations reported
@whoopsmith
Copy link
Copy Markdown
Contributor Author

:) The Codacy quality reviewer doesn't like my misra test files.

@danmar
Copy link
Copy Markdown
Collaborator

danmar commented Oct 18, 2018

ok hmm codacy should ignore the test folders.

@danmar danmar merged commit f286325 into cppcheck-opensource:master Oct 18, 2018
@whoopsmith
Copy link
Copy Markdown
Contributor Author

@danmar Since you are squashing my commits into a single commit would you prefer I create that PR that way from the start? If so I will re-format the commit message differently so they read better.

@danmar
Copy link
Copy Markdown
Collaborator

danmar commented Oct 18, 2018

yes that would be preferable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants