Show line number when suggesting std::transform or std::copy#1385
Merged
Conversation
amai2012
reviewed
Sep 20, 2018
| "}\n", | ||
| true); | ||
| ASSERT_EQUALS("(style) Consider using std::transform algorithm instead of a raw loop.\n", errout.str()); | ||
| ASSERT_EQUALS("[test.cpp:4]: (style) Consider using std::transform algorithm instead of a raw loop.\n", errout.str()); |
Collaborator
There was a problem hiding this comment.
The loop starts in line 3 - though the trigger for the message is the content which is in line 4.
In case of nested loops the message could be ambiguous.
Contributor
Author
There was a problem hiding this comment.
Yea, all the messages point inside the loops, so its consistent with the other useStlAlgorithm messages. I can update the messages in another PR. This is mainly to fix the problem with messages that have no location for them.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes a bug where the source location wasn't shown when suggesting std::transform or std::copy with container inserts.