Makes FakeRepository from Ch5 more like one from Ch2 - #355
Merged
Conversation
…stent with the current shape of it in Chapter 2.
Contributor
|
oo nice catch thanks Filip! am always on the fence about classmethods! i find the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It looks like
FakeRepositoryin Chapter 5 introduced in 50bfa5c was left in original state, while in the meantime ABC was introduced into chapter 2 in 1795366, so here we make it match again.As a side note, the alternative approach would be to use
classmethodinstead ofstaticmethodbut it depends very much on personal preferences. It's not what I propose in that PR, but it could look like that: