Implement edge ngram tokenizer for Bloodhound#93
Merged
Conversation
Add tests for ngram tokenizer Add tokenizer examples to Bloodhound readme Build dist NPM & Bower version patch to 0.11.2
jlbooker
approved these changes
Oct 31, 2016
Contributor
jlbooker
left a comment
There was a problem hiding this comment.
Looks good to me, and thanks for the additional documentation around tokenizers. 👍
Contributor
|
@CoreSystemDevelopment Could you give this a review before we merge? |
core-system-dev
approved these changes
Nov 1, 2016
Contributor
core-system-dev
left a comment
There was a problem hiding this comment.
@jlbooker LGTM, I talked to @lenovouser today and he told me than he was busy the last few months but will check out the repo and PR's etc. this week 👍
Contributor
Author
|
@jlbooker Ok sounds good! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Further to issue #91 I have implemented an Ngram tokenizer for Bloodhound along with the corresponding tests. I noticed the tokenizers were not documented in doc/Bloodhound.md so I added a Tokenizers section.
Not sure what the protocol is with regards to versioning and building, but I have built and bumped the package to 0.11.2.