Skip to content

Update Serving API - from backend PR #7097 #425

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
convert-bot-app wants to merge 1 commit into
base: main-convert
Choose a base branch
from
Open

Update Serving API - from backend PR #7097 #425

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
64 changes: 53 additions & 11 deletions packages/types/src/config/types.gen.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
/**
* Audience unique key
*/
key?: string;
key?: (string) | null;
/**
* Audience Name
*/
Expand Down Expand Up @@ -409,6 +409,10 @@
BUCKETED_INTO_SEGMENT = 'bucketed_into_segment'
}

export enum ExperienceKeyBucketedMatchRulesTypes {
BUCKETED_INTO_EXPERIENCE_KEY = 'bucketed_into_experience_key'
}

export enum DayOfWeekMatchRulesTypes {
LOCAL_TIME_DAY_OF_WEEK = 'local_time_day_of_week',
PROJECT_TIME_DAY_OF_WEEK = 'project_time_day_of_week'
Expand Down Expand Up @@ -436,7 +440,7 @@
WEATHER_CONDITION = 'weather_condition'
}

export type RulesTypes = TextMatchRulesTypes & NumericMatchRulesTypes & BoolMatchRulesTypes & KeyValueMatchRulesTypes & VisitorDataExistsMatchRulesTypes & CookieMatchRulesTypes & CountryMatchRulesTypes & VisitorTypeMatchRulesTypes & LanguageMatchRulesTypes & GoalTriggeredMatchRulesTypes & SegmentBucketedMatchRulesTypes & DayOfWeekMatchRulesTypes & HourOfDayMatchRulesTypes & MinuteOfHourMatchRulesTypes & BrowserNameMatchRulesTypes & OsMatchRulesTypes & WeatherConditionMatchRulesTypes;
export type RulesTypes = TextMatchRulesTypes & NumericMatchRulesTypes & BoolMatchRulesTypes & KeyValueMatchRulesTypes & VisitorDataExistsMatchRulesTypes & CookieMatchRulesTypes & CountryMatchRulesTypes & VisitorTypeMatchRulesTypes & LanguageMatchRulesTypes & GoalTriggeredMatchRulesTypes & SegmentBucketedMatchRulesTypes & ExperienceKeyBucketedMatchRulesTypes & DayOfWeekMatchRulesTypes & HourOfDayMatchRulesTypes & MinuteOfHourMatchRulesTypes & BrowserNameMatchRulesTypes & OsMatchRulesTypes & WeatherConditionMatchRulesTypes;

Check warning on line 443 in packages/types/src/config/types.gen.ts

View check run for this annotation

SonarQubeCloud / SonarCloud Code Analysis

'never' overrides all other types in this intersection type. 


See more on https://sonarcloud.io/project/issues?id=convertcom_javascript-sdk&issues=AZ_b3JvU25556JJ6543P&open=AZ_b3JvU25556JJ6543P&pullRequest=425

export type GenericTextMatchRule = BaseRuleWithStringValue & {
rule_type: TextMatchRulesTypes;
Expand Down Expand Up @@ -554,6 +558,13 @@
});
};

export type ExperienceKeyBucketedMatchRule = BaseRuleWithStringValue & {
rule_type: ExperienceKeyBucketedMatchRulesTypes;
matching?: (BaseMatch & {
match_type?: ChoiceMatchingOptions;
});
};

export type ExperienceBucketedMatchRule = BaseRuleWithExperienceBucketedValue & {
rule_type: string;
matching?: (BaseMatch & {
Expand Down Expand Up @@ -603,11 +614,11 @@
});
};

export type RuleElementNoUrl = GenericTextMatchRule | GenericNumericMatchRule | GenericBoolMatchRule | CookieMatchRule | GenericTextKeyValueMatchRule | GenericNumericKeyValueMatchRule | GenericBoolKeyValueMatchRule | CountryMatchRule | LanguageMatchRule | GoalTriggeredMatchRule | SegmentBucketedMatchRule | DayOfWeekMatchRule | HourOfDayMatchRule | MinuteOfHourMatchRule | BrowserNameMatchRule | OsMatchRule | WeatherConditionMatchRule | VisitorTypeMatchRule | JsConditionMatchRule | VisitorDataExistsMatchRule;
export type RuleElementNoUrl = GenericTextMatchRule | GenericNumericMatchRule | GenericBoolMatchRule | CookieMatchRule | GenericTextKeyValueMatchRule | GenericNumericKeyValueMatchRule | GenericBoolKeyValueMatchRule | CountryMatchRule | LanguageMatchRule | GoalTriggeredMatchRule | SegmentBucketedMatchRule | ExperienceKeyBucketedMatchRule | DayOfWeekMatchRule | HourOfDayMatchRule | MinuteOfHourMatchRule | BrowserNameMatchRule | OsMatchRule | WeatherConditionMatchRule | VisitorTypeMatchRule | JsConditionMatchRule | VisitorDataExistsMatchRule;

export type RuleElement = GenericTextMatchRule | GenericNumericMatchRule | GenericBoolMatchRule | GenericTextKeyValueMatchRule | GenericNumericKeyValueMatchRule | GenericBoolKeyValueMatchRule | CookieMatchRule | CountryMatchRule | LanguageMatchRule | GoalTriggeredMatchRule | SegmentBucketedMatchRule | DayOfWeekMatchRule | HourOfDayMatchRule | MinuteOfHourMatchRule | BrowserNameMatchRule | OsMatchRule | WeatherConditionMatchRule | VisitorTypeMatchRule | JsConditionMatchRule;
export type RuleElement = GenericTextMatchRule | GenericNumericMatchRule | GenericBoolMatchRule | GenericTextKeyValueMatchRule | GenericNumericKeyValueMatchRule | GenericBoolKeyValueMatchRule | CookieMatchRule | CountryMatchRule | LanguageMatchRule | GoalTriggeredMatchRule | SegmentBucketedMatchRule | ExperienceKeyBucketedMatchRule | DayOfWeekMatchRule | HourOfDayMatchRule | MinuteOfHourMatchRule | BrowserNameMatchRule | OsMatchRule | WeatherConditionMatchRule | VisitorTypeMatchRule | JsConditionMatchRule;

export type RuleElementAudience = GenericTextMatchRule | GenericNumericMatchRule | GenericBoolMatchRule | GenericTextKeyValueMatchRule | GenericNumericKeyValueMatchRule | GenericBoolKeyValueMatchRule | CookieMatchRule | CountryMatchRule | LanguageMatchRule | GoalTriggeredMatchRule | SegmentBucketedMatchRule | DayOfWeekMatchRule | HourOfDayMatchRule | MinuteOfHourMatchRule | BrowserNameMatchRule | OsMatchRule | WeatherConditionMatchRule | VisitorTypeMatchRule | JsConditionMatchRule | VisitorDataExistsMatchRule;
export type RuleElementAudience = GenericTextMatchRule | GenericNumericMatchRule | GenericBoolMatchRule | GenericTextKeyValueMatchRule | GenericNumericKeyValueMatchRule | GenericBoolKeyValueMatchRule | CookieMatchRule | CountryMatchRule | LanguageMatchRule | GoalTriggeredMatchRule | SegmentBucketedMatchRule | ExperienceKeyBucketedMatchRule | DayOfWeekMatchRule | HourOfDayMatchRule | MinuteOfHourMatchRule | BrowserNameMatchRule | OsMatchRule | WeatherConditionMatchRule | VisitorTypeMatchRule | JsConditionMatchRule | VisitorDataExistsMatchRule;

export enum TextMatchingOptions {
MATCHES = 'matches',
Expand Down Expand Up @@ -849,6 +860,12 @@
*
*/
sampling_rate?: 5 | 10 | 20 | 30 | 40 | 50;
/**
* Maximum number of visits per variation used when generating a heatmap for this project.
* Applies to newly created heatmaps when an experience is activated.
*
*/
heatmap_visits_limit?: 2500 | 5000 | 10000 | 15000;
};

/**
Expand All @@ -865,6 +882,18 @@
'_50' = 50
}

/**
* Maximum number of visits per variation used when generating a heatmap for this project.
* Applies to newly created heatmaps when an experience is activated.
*
*/
export enum heatmap_visits_limit {
'_2500' = 2500,
'_5000' = 5000,
'_10000' = 10000,
'_15000' = 15000
}

/**
* The method used for detecting and handling order outliers in revenue or product count tracking:
* - `none`: No outlier detection is applied.
Expand Down Expand Up @@ -970,6 +999,11 @@
*/
export type ConcurrencyKey = (string) | null;

/**
* Device fingerprint computed by client-side.
*/
export type UserAuthMetaData = string;

Check warning on line 1005 in packages/types/src/config/types.gen.ts

View check run for this annotation

SonarQubeCloud / SonarCloud Code Analysis

Remove this redundant type alias and replace its occurrences with "string". 


See more on https://sonarcloud.io/project/issues?id=convertcom_javascript-sdk&issues=AZ_b3JvU25556JJ6543Q&open=AZ_b3JvU25556JJ6543Q&pullRequest=425

/**
* Response containing project's config data needed in order to serve experiences
*/
Expand Down Expand Up @@ -1627,7 +1661,7 @@
/**
* Experience readable key that uniquely identifies this experience
*/
key?: string;
key?: (string) | null;
/**
* List of locations IDs on which this experience is presented. Either this or **site_area** is given but should not be both.
*/
Expand Down Expand Up @@ -1769,7 +1803,7 @@
/**
* Variation Key
*/
key?: string;
key?: (string) | null;
/**
* Percentage of traffic allocation for this variation, as a number from 0 to 10000.
* For an experience, the sum of the traffic allocations for all variations cannot be greater than 10000.
Expand Down Expand Up @@ -1827,7 +1861,7 @@
/**
* A unique per project level identifier
*/
key?: string;
key?: (string) | null;
/**
* An array of user-defined variables of a feature.
*/
Expand Down Expand Up @@ -1874,7 +1908,7 @@
/**
* Goal Key
*/
key?: string;
key?: (string) | null;
/**
* List of goal types to be returned
*/
Expand Down Expand Up @@ -2165,7 +2199,7 @@
/**
* Location unique key
*/
key?: string;
key?: (string) | null;
/**
* Location Name
*/
Expand Down Expand Up @@ -2391,6 +2425,10 @@
* Attempt to pull revenue data from Google Analytics Revenue Tracking code.
*/
auto_revenue_tracking?: boolean;
/**
* When enabled, the experience_impression event is sent only the first time a visitor is exposed to an experience, instead of on every subsequent qualifying page view. Opt-in and disabled by default.
*/
track_first_exposure_only?: boolean;
};

export type ProjectIntegrationGA3 = ProjectGASettingsBase & IntegrationGA3;
Expand All @@ -2415,7 +2453,7 @@
/**
* Segment unique key
*/
key?: string;
key?: (string) | null;
/**
* Segment Name
*/
Expand Down Expand Up @@ -2558,6 +2596,10 @@
* Campaign string
*/
campaign?: string;
/**
* Content string (ad-creative identifier from utm_content)
*/
content?: string;
/**
* Type of the visitor
*/
Expand Down
Loading