Skip to content

Main convert #402

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
abbaseya merged 6 commits into from
Jun 5, 2026
Merged

Main convert #402

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
49b2af0
fix(utils): classify browser Web Workers as browser runtime in HttpCl…
abbaseya Jun 5, 2026
7d47d87
fix(js-sdk): pick up Web Worker runtime detection fix from js-sdk-utils
abbaseya Jun 5, 2026
d852dc3
fix(utils): tolerate null self in worker runtime detection
abbaseya Jun 5, 2026
e17f06e
Merge pull request #401 from convertcom/fix/worker-runtime-misdetecte…
JosephSamirL Jun 5, 2026
ff602b6
Merge branch 'main' into main-convert
abbaseya Jun 5, 2026
095b70f
Merge pull request #403 from convertcom/fix/sync-main
abbaseya Jun 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions packages/utils/src/http-client.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -137,6 +137,20 @@ const determineRuntime = (): RuntimeResult => {
return {runtime: 'browser'};
}

// Browser Web Workers have no `window` but are still browser runtimes.
// `importScripts` exists only in browser worker scopes — server runtimes
// (Node.js) and edge runtimes (e.g. Cloudflare Workers) do not expose it.
// Without this check a Web Worker falls through to 'server-with-fetch' and
// server-side-only behavior leaks into real browsers (the ConvertAgent
// User-Agent announcement below forced a CORS preflight the signals
// endpoint rejected, breaking every signals worker upload).
if (
typeof self !== 'undefined' &&
typeof (self as {importScripts?: unknown})?.importScripts === 'function'
) {
return {runtime: 'browser'};
}

// if window is not available, but fetch is, then we're on a server that has the fetch API available
if (typeof fetch === 'function') {
return {runtime: 'server-with-fetch'};
Expand Down
Loading