build(deps): Bump pug from 2.0.0-beta11 to 3.0.1 in /packages/demo-nodejs - #2
Closed
dependabot[bot] wants to merge 1 commit into
Closed
Conversation
Bumps [pug](https://github.com/pugjs/pug) from 2.0.0-beta11 to 3.0.1. - [Release notes](https://github.com/pugjs/pug/releases) - [Commits](https://github.com/pugjs/pug/compare/pug@2.0.0-beta11...pug@3.0.1) --- updated-dependencies: - dependency-name: pug dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com>
Author
|
OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting If you change your mind, just re-open this PR and I'll resolve any conflicts on it. |
dependabot
Bot
deleted the
dependabot/npm_and_yarn/packages/demo-nodejs/pug-3.0.1
branch
April 7, 2023 09:51
JosephSamirL
added a commit
that referenced
this pull request
May 12, 2026
Issues from the review (#1, #2, #3, #6, #7, #8 in review numbering; #4 deferred to a follow-up). #1 — convert() regression: when a global ruleDataProvider is set, the previous `if (goalRule || this._ruleDataProvider)` always entered the rule-eval block and hit `if (!goal?.rules) return`, silently dropping every rule-less goal conversion. Gate on `goal.rules` first; preserve the pre-PR contract that an explicit `goalRule` on a rule-less goal still returns undefined. #2 — Per-change marker IDs now scoped by experience + variation + change id (conv-chg-${experienceId}-${variationId}-${change.id}-…) instead of just `change.id`. Defense against future ID-semantics changes or two configs merged on one page. #3 — Validate ruleDataProvider at DataManager construction. A provider missing the `name: 'RuleData'` discriminator would fall through RuleManager's flat-key branch and silently return false for every rule, breaking all audience matching with no error surfaced. Warn and ignore the provider so the misconfiguration is visible. Also introduces a proper `RuleDataProvider` interface in @convertcom/js-sdk-types replacing the raw `Record<string, any>` on Config.ruleDataProvider, so consumers get type guidance. #6 — Replace `(change as any).data` access in runVariation with a structural type assertion narrowed to the css/js/custom_js subset. #7 — Delete the no-op "Should store ruleDataProvider on the DataManager instance" test; the next test covers the same behavior. #8 — Add four missing tests: - runVariation execution order (global_css → global_js → per-change css → js → custom_js) verified via appendChild monkey-patch - runVariation warn-and-continue when options.experience is omitted and the experienceKey isn't in config - convert() fires for a rule-less goal when ruleDataProvider is set (regression guard for #1) - DataManager warns and ignores a provider missing the `name` discriminator (regression guard for #3) Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
JosephSamirL
added a commit
that referenced
this pull request
May 12, 2026
Three issues from the follow-up review (issue #3 in that review, about the types.gen.ts manual override, deferred per request). Review #1 — `runExperience` honors `experienceTypes` filter. The singular path silently ignored the option even though BucketingAttributes advertised it. Wire `experienceTypes` through `Context.runExperience` and `ExperienceManager.selectVariation`/ `selectVariationById`: short-circuit to `null` when the experience type isn't in the filter. Brings parity with `runExperiences`, `runFeature`, and `runFeatures`. Review #2 — Flip `ruleDataProvider` precedence and document. Previous behavior: the globally-configured provider always won over per-call args (`provider || arg`). That's the opposite of how config-vs-args APIs normally layer and silently discarded an explicit `goalRule` on `trackConversion`. Flipped to `arg || provider` at all four DataManager rule-eval call sites (site_area locations, selectLocations, filterMatchedRecordsWithRule, convert). Also broadened the two outer `if (visitorProperties)` / `if (locationProperties)` guards so the provider remains reachable when the caller omits the per-call arg. Updated tests: the original "provider beats per-call props" test becomes "provider is used when no per-call props are supplied", plus a new "per-call props win over provider" test guarding the flip. Precedence is now documented on `Config.ruleDataProvider` and in `RuleDataProvider.ts`. Review #4 — `experienceTypes: []` means "no matches", not "all". Previously `if (!typeFilter?.length)` treated `[]` the same as `undefined`. Empty array now correctly means "zero types allowed — no experiences match", matching standard array-filter intuition. `undefined` and omission still mean "no filter applied". Behavior is documented on `BucketingAttributes.experienceTypes` and the `selectVariations` source. New test asserts empty-array → empty result. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps pug from 2.0.0-beta11 to 3.0.1.
Release notes
Sourced from pug's releases.
... (truncated)
Commits
991e78ffix: sanitise and escape theprettyoption (#3314)06baa52Fix TypeScript and add eachOf token definition (#3262)13e46e9chore: update with (#3259)c077df4docs: fix rolling versions linkccba7daci: publish canary release (#3257)24a7b8echore: remove get-repo dependency (#3256)8288ec5ci: fix some problems with the workflows and add dry-run (#3254)eca9342chore: update is-expression and jest (#3253)9e96bb7feat: allow filters to read non-text include files (#3213)bb0731fchore: use minimal settings to format test files (#3245)Maintainer changes
This version was pushed to npm by pug-bot, a new releaser for pug since your current version.
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)You can disable automated security fix PRs for this repo from the Security Alerts page.