-
Notifications
You must be signed in to change notification settings - Fork 3
Comparing changes
Open a pull request
base repository: convertcom/javascript-sdk
base: 8abe059
head repository: convertcom/javascript-sdk
compare: f4741f9
- 11 commits
- 32 files changed
- 3 contributors
Commits on Sep 23, 2025
-
Configuration menu - View commit details
-
Copy full SHA for ee49dc8 - Browse repository at this point
Copy the full SHA ee49dc8View commit details -
Configuration menu - View commit details
-
Copy full SHA for aff9810 - Browse repository at this point
Copy the full SHA aff9810View commit details -
Configuration menu - View commit details
-
Copy full SHA for 951c313 - Browse repository at this point
Copy the full SHA 951c313View commit details
Commits on Oct 5, 2025
-
Configuration menu - View commit details
-
Copy full SHA for 5c6af05 - Browse repository at this point
Copy the full SHA 5c6af05View commit details
Commits on Oct 6, 2025
-
Configuration menu - View commit details
-
Copy full SHA for 6cc8fec - Browse repository at this point
Copy the full SHA 6cc8fecView commit details -
fix: serve WASM file in Karma UMD browser tests
Configure Karma to properly serve the decisions_core_bg.wasm file during UMD bundle browser tests, resolving the "Cannot read properties of undefined (reading 'wasmdecisionengine_new')" error. Changes: - Added WASM file to Karma files array with {included: false, served: true} - This allows the UMD bundle to fetch the WASM file via HTTP during tests - WASM file is already copied to lib/ by copy-wasm.js during build The pkg-node/browser/ version of decisions-core uses async WASM loading which requires the WASM file to be accessible via fetch(). By serving it through Karma, the browser tests can now properly initialize the Rust decision engine. Note: CJS browser tests at index.browser.cjs.tests.js cannot use Rust decider because pkg-node/decisions_core.js uses require('fs') which is not available in browsers. These tests should either be skipped when useRustDecider is enabled, or they should test fallback behavior only. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>Configuration menu - View commit details
-
Copy full SHA for 40247d0 - Browse repository at this point
Copy the full SHA 40247d0View commit details -
refactor: rename Rust decider to Core decider
- Renamed all 'Rust' references to 'Core' in variable names, class names, methods, and config properties - Renamed rust-decider.ts to core-decider.ts - Updated config property from useRustDecider to useCoreDecider - Added CoreDecider type definition in types package - Updated DataManagerInterface to properly expose coreDecider property - Fixed Rollup configuration to use browser version of decisions-core for UMD bundles - Added exportConditions for proper conditional exports resolution - Ensures __dirname is not present in browser bundles 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
Configuration menu - View commit details
-
Copy full SHA for 632ab5d - Browse repository at this point
Copy the full SHA 632ab5dView commit details
Commits on Oct 7, 2025
-
fix: await SDK ready in UMD browser tests before creating context
Updated test hooks to properly await SDK initialization when using Core decider. The WASM module loads asynchronously, so tests must wait for the READY event before calling createContext(). Changes: - Made test "Shoud successfully create visitor context" async and added await - Updated "Basic SDK methods" before() hook to be async and await onReady() - Updated "Test invalid visitor" before() hook to be async and await onReady() All 20 UMD browser tests now pass with Core decider enabled. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
Configuration menu - View commit details
-
Copy full SHA for 3fef38e - Browse repository at this point
Copy the full SHA 3fef38eView commit details -
chore: update import formatting and error message
- Standardized import statement formatting with spaces around braces - Updated error log message from "Rust decider" to "Core decider" - Updated yarn.lock after dependency reinstallation 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
Configuration menu - View commit details
-
Copy full SHA for 2f73042 - Browse repository at this point
Copy the full SHA 2f73042View commit details -
docs: fix README.md instruction order and typos
- Reordered demo instructions: build packages before starting servers - Added build step to Installation section - Fixed typo: "Prevview" → "Preview" - Fixed typo: "enviroment" → "environment" All demos now follow: Build → Create env → Start → Test 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
Configuration menu - View commit details
-
Copy full SHA for c920bfb - Browse repository at this point
Copy the full SHA c920bfbView commit details
Commits on Oct 13, 2025
-
Configuration menu - View commit details
-
Copy full SHA for f4741f9 - Browse repository at this point
Copy the full SHA f4741f9View commit details
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff 8abe059...f4741f9