Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: convertcom/javascript-sdk
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 8abe059
Choose a base ref
...
head repository: convertcom/javascript-sdk
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: f4741f9
Choose a head ref
  • 11 commits
  • 32 files changed
  • 3 contributors

Commits on Sep 23, 2025

  1. Configuration menu
    Copy the full SHA
    ee49dc8 View commit details
    Browse the repository at this point in the history
  2. chore: release main

    github-actions[bot] authored and abbaseya committed Sep 23, 2025
    Configuration menu
    Copy the full SHA
    aff9810 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    951c313 View commit details
    Browse the repository at this point in the history

Commits on Oct 5, 2025

  1. Configuration menu
    Copy the full SHA
    5c6af05 View commit details
    Browse the repository at this point in the history

Commits on Oct 6, 2025

  1. Configuration menu
    Copy the full SHA
    6cc8fec View commit details
    Browse the repository at this point in the history
  2. fix: serve WASM file in Karma UMD browser tests

    Configure Karma to properly serve the decisions_core_bg.wasm file during
    UMD bundle browser tests, resolving the "Cannot read properties of undefined
    (reading 'wasmdecisionengine_new')" error.
    
    Changes:
    - Added WASM file to Karma files array with {included: false, served: true}
    - This allows the UMD bundle to fetch the WASM file via HTTP during tests
    - WASM file is already copied to lib/ by copy-wasm.js during build
    
    The pkg-node/browser/ version of decisions-core uses async WASM loading
    which requires the WASM file to be accessible via fetch(). By serving it
    through Karma, the browser tests can now properly initialize the Rust
    decision engine.
    
    Note: CJS browser tests at index.browser.cjs.tests.js cannot use Rust
    decider because pkg-node/decisions_core.js uses require('fs') which is
    not available in browsers. These tests should either be skipped when
    useRustDecider is enabled, or they should test fallback behavior only.
    
    🤖 Generated with [Claude Code](https://claude.com/claude-code)
    
    Co-Authored-By: Claude <noreply@anthropic.com>
    abbaseya and claude committed Oct 6, 2025
    Configuration menu
    Copy the full SHA
    40247d0 View commit details
    Browse the repository at this point in the history
  3. refactor: rename Rust decider to Core decider

    - Renamed all 'Rust' references to 'Core' in variable names, class names, methods, and config properties
    - Renamed rust-decider.ts to core-decider.ts
    - Updated config property from useRustDecider to useCoreDecider
    - Added CoreDecider type definition in types package
    - Updated DataManagerInterface to properly expose coreDecider property
    - Fixed Rollup configuration to use browser version of decisions-core for UMD bundles
      - Added exportConditions for proper conditional exports resolution
      - Ensures __dirname is not present in browser bundles
    
    🤖 Generated with [Claude Code](https://claude.com/claude-code)
    
    Co-Authored-By: Claude <noreply@anthropic.com>
    abbaseya and claude committed Oct 6, 2025
    Configuration menu
    Copy the full SHA
    632ab5d View commit details
    Browse the repository at this point in the history

Commits on Oct 7, 2025

  1. fix: await SDK ready in UMD browser tests before creating context

    Updated test hooks to properly await SDK initialization when using
    Core decider. The WASM module loads asynchronously, so tests must
    wait for the READY event before calling createContext().
    
    Changes:
    - Made test "Shoud successfully create visitor context" async and added await
    - Updated "Basic SDK methods" before() hook to be async and await onReady()
    - Updated "Test invalid visitor" before() hook to be async and await onReady()
    
    All 20 UMD browser tests now pass with Core decider enabled.
    
    🤖 Generated with [Claude Code](https://claude.com/claude-code)
    
    Co-Authored-By: Claude <noreply@anthropic.com>
    abbaseya and claude committed Oct 7, 2025
    Configuration menu
    Copy the full SHA
    3fef38e View commit details
    Browse the repository at this point in the history
  2. chore: update import formatting and error message

    - Standardized import statement formatting with spaces around braces
    - Updated error log message from "Rust decider" to "Core decider"
    - Updated yarn.lock after dependency reinstallation
    
    🤖 Generated with [Claude Code](https://claude.com/claude-code)
    
    Co-Authored-By: Claude <noreply@anthropic.com>
    abbaseya and claude committed Oct 7, 2025
    Configuration menu
    Copy the full SHA
    2f73042 View commit details
    Browse the repository at this point in the history
  3. docs: fix README.md instruction order and typos

    - Reordered demo instructions: build packages before starting servers
    - Added build step to Installation section
    - Fixed typo: "Prevview" → "Preview"
    - Fixed typo: "enviroment" → "environment"
    
    All demos now follow: Build → Create env → Start → Test
    
    🤖 Generated with [Claude Code](https://claude.com/claude-code)
    
    Co-Authored-By: Claude <noreply@anthropic.com>
    abbaseya and claude committed Oct 7, 2025
    Configuration menu
    Copy the full SHA
    c920bfb View commit details
    Browse the repository at this point in the history

Commits on Oct 13, 2025

  1. Configuration menu
    Copy the full SHA
    f4741f9 View commit details
    Browse the repository at this point in the history
Loading