Add: ResponseHeaderTimeout to image pull HTTP transport#13164
Merged
mikebrow merged 1 commit intocontainerd:mainfrom Apr 20, 2026
Merged
Add: ResponseHeaderTimeout to image pull HTTP transport#13164mikebrow merged 1 commit intocontainerd:mainfrom
mikebrow merged 1 commit intocontainerd:mainfrom
Conversation
Signed-off-by: Mujib Ahasan <ahasanmujib8@gmail.com>
Contributor
Author
|
@AkihiroSuda, @mikebrow just a gentle ping on this PR when you get some time. Would really appreciate your review. |
AkihiroSuda
approved these changes
Apr 18, 2026
djdongjin
approved these changes
Apr 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Current cri image pull transport sets dial and tls handshake timeouts, but not a response header timeout. This can leave pulls waiting for minutes when a registry connection is established but the registry server became temporarily unresponsive before sending response. This change adds
ResponseHeaderTimeouttoDefaultHTTPTransport()so that this allows the client to fail fast and retry sooner, instead of waiting minutes on a stalled connection.fixes: #13006