Skip to content

Update version#1

Merged
BastianZim merged 14 commits intoconda-forge:masterfrom
BastianZim:update-version
Apr 14, 2021
Merged

Update version#1
BastianZim merged 14 commits intoconda-forge:masterfrom
BastianZim:update-version

Conversation

@BastianZim
Copy link
Copy Markdown
Member

@BastianZim BastianZim commented Apr 9, 2021

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

@BastianZim BastianZim self-assigned this Apr 9, 2021
@BastianZim BastianZim requested a review from mfeurer as a code owner April 9, 2021 13:00
@conda-forge-linter
Copy link
Copy Markdown

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@BastianZim
Copy link
Copy Markdown
Member Author

@conda-forge-admin, please rerender

@BastianZim BastianZim changed the title Change to PyPI source Change to PyPI source and update version Apr 9, 2021
@BastianZim BastianZim added the automerge Merge the PR when CI passes label Apr 9, 2021
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 9, 2021

Hi! This is the friendly conda-forge automerge bot!

I considered the following status checks when analyzing this PR:

  • linter: passed
  • azure: failed

Thus the PR was not passing and not merged.

@BastianZim BastianZim removed the automerge Merge the PR when CI passes label Apr 9, 2021
@BastianZim
Copy link
Copy Markdown
Member Author

@conda-forge-admin, please rerender

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 9, 2021

Hi! This is the friendly automated conda-forge-webservice.
I tried to rerender for you, but it looks like there was nothing to do.

@BastianZim BastianZim added the automerge Merge the PR when CI passes label Apr 9, 2021
@BastianZim BastianZim removed the automerge Merge the PR when CI passes label Apr 9, 2021
@BastianZim BastianZim marked this pull request as draft April 9, 2021 14:37
@BastianZim
Copy link
Copy Markdown
Member Author

@conda-forge-admin, please rerender

@github-actions
Copy link
Copy Markdown
Contributor

Hi! This is the friendly automated conda-forge-webservice.
I tried to rerender for you, but it looks like there was nothing to do.

@BastianZim
Copy link
Copy Markdown
Member Author

@mfeurer I tried upgrading the package to the new version but the tests are failing with a path error when importing the package: https://dev.azure.com/conda-forge/feedstock-builds/_build/results?buildId=302339&view=logs&j=656edd35-690f-5c53-9ba3-09c10d0bea97&t=e5c8ab1d-8ff9-5cae-b332-e15ae582ed2d

From what I can see in the code, you don't necessarily need this file so would it be possible to include this case in the exception, or do you maybe have a different idea how to fix this?

Line: https://github.com/openml/openml-python/blob/e336ab35ef2160ca0885d78eef59cd8d272051ee/openml/config.py#L205-L212

@mfeurer
Copy link
Copy Markdown
Contributor

mfeurer commented Apr 13, 2021

From what I can see in the code, you don't necessarily need this file so would it be possible to include this case in the exception, or do you maybe have a different idea how to fix this?

I think using os.makedirs(config_dir, exists=True) would solve the issue. Would this be easy for you to test? If yes I could then add this to the next (minor) release.

@BastianZim
Copy link
Copy Markdown
Member Author

Would this be easy for you to test?

Yes, I'll just create a patch and test that. Will try that later.

@BastianZim
Copy link
Copy Markdown
Member Author

Same problem occurs in https://github.com/openml/openml-python/blob/e336ab35ef2160ca0885d78eef59cd8d272051ee/openml/config.py#L238

Will try to the patch there as well.

@BastianZim BastianZim marked this pull request as ready for review April 13, 2021 10:59
@BastianZim
Copy link
Copy Markdown
Member Author

@conda-forge-admin, please rerender

@github-actions
Copy link
Copy Markdown
Contributor

Hi! This is the friendly automated conda-forge-webservice.
I tried to rerender for you, but it looks like there was nothing to do.

@BastianZim
Copy link
Copy Markdown
Member Author

@mfeurer I had to patch it in two places but seems to be working now. Can you just quickly confirm that the second patch is not breaking anything internally? Otherwise, this should be good to go.

@BastianZim BastianZim changed the title Change to PyPI source and update version Update version Apr 13, 2021
@mfeurer
Copy link
Copy Markdown
Contributor

mfeurer commented Apr 14, 2021

It should not break anything. I just created a PR to fix this upstream as other projects are also hit by this error: openml/openml-python#1053

@BastianZim
Copy link
Copy Markdown
Member Author

Ok perfect, thanks for the feedback. Once your PR is merged I'll also merge this to keep the versions in sync and remove the patches again once a new release is available.

@BastianZim BastianZim merged commit 8e0b9c6 into conda-forge:master Apr 14, 2021
@BastianZim BastianZim deleted the update-version branch April 14, 2021 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants