Update version#1
Conversation
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
|
@conda-forge-admin, please rerender |
…nda-forge-pinning 2021.04.09.07.49.51
|
Hi! This is the friendly conda-forge automerge bot! I considered the following status checks when analyzing this PR:
Thus the PR was not passing and not merged. |
|
@conda-forge-admin, please rerender |
…-feedstock into update-version
|
Hi! This is the friendly automated conda-forge-webservice. |
|
@conda-forge-admin, please rerender |
|
Hi! This is the friendly automated conda-forge-webservice. |
|
@mfeurer I tried upgrading the package to the new version but the tests are failing with a path error when importing the package: https://dev.azure.com/conda-forge/feedstock-builds/_build/results?buildId=302339&view=logs&j=656edd35-690f-5c53-9ba3-09c10d0bea97&t=e5c8ab1d-8ff9-5cae-b332-e15ae582ed2d From what I can see in the code, you don't necessarily need this file so would it be possible to include this case in the exception, or do you maybe have a different idea how to fix this? |
I think using |
Yes, I'll just create a patch and test that. Will try that later. |
|
Same problem occurs in https://github.com/openml/openml-python/blob/e336ab35ef2160ca0885d78eef59cd8d272051ee/openml/config.py#L238 Will try to the patch there as well. |
|
@conda-forge-admin, please rerender |
|
Hi! This is the friendly automated conda-forge-webservice. |
|
@mfeurer I had to patch it in two places but seems to be working now. Can you just quickly confirm that the second patch is not breaking anything internally? Otherwise, this should be good to go. |
|
It should not break anything. I just created a PR to fix this upstream as other projects are also hit by this error: openml/openml-python#1053 |
|
Ok perfect, thanks for the feedback. Once your PR is merged I'll also merge this to keep the versions in sync and remove the patches again once a new release is available. |
Checklist
0(if the version changed)conda-smithy(Use the phrase@conda-forge-admin, please rerenderin a comment in this PR for automated rerendering)