Repository navigation
Conversation
An opening fence like "```~/.bashrc" or "~~~`info`" was not recognized, because backticks and tildes after the first character were counted as part of the fence. The fence is only the run of the first character, so the info string can start directly after it with the other character.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An opening fence followed directly by the other fence character wasn't recognized, so these became paragraphs:
checkOpenercounted all backticks and tildes at the start of the line together and gave up when both were present. Only the run of the first character is the fence, and the info string can contain the other character (backtick fences only disallow backticks in the info string), so it now counts just that run.`` is still not a fence (backtickAndTildeCantBeMixed` passes unchanged).cmark and commonmark.js both parse the two examples above as code blocks with info strings
~/.bashrcand`info`.Tests added in
FencedCodeBlockParserTest, both fail without the change.mvn test(all modules) andmvn spotless:checkpass.